beginGestureWithEvent/endGestureWithEvent no longer called when linking against macOS 10.11 or later SDK |
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:51.0) Gecko/20100101 Firefox/51.0 Steps to reproduce the problem: Pinch-zoom will stop working when Chrome builds switch from the 10.10 SDK to a newer SDK in issue 624049 . See https://developer.apple.com/reference/appkit/nsresponder/1526368-begingesturewithevent In particular: "Note that this method is no longer called on apps that link against macOS 10.11 and later. If you need to access the phases of a specific gesture, you can implement the responder for that gesture and examine its phase property instead." What is the expected behavior? What went wrong? Did this work before? No Chrome version: Channel: canary OS Version: OS X 10.12 Flash Version:
,
Jan 13 2017
erkichen@ - are we talking about linking to the 10.12 SDK in Issue 624049 ? Or is that bug just about laying the groundwork for us switching to link against 10.12?
,
Jan 17 2017
When Issue 624049 is fixed, Chrome will be building against 10.12 SDK.
,
Jan 17 2017
OK. Is there a tracking bug building against the 10.12 SDK? This one should be a blocker for that.
,
Jan 17 2017
,
Feb 7 2017
,
Feb 7 2017
https://codereview.chromium.org/2682593005/ is a start but it needs better tests.
,
Feb 7 2017
Mac has a bunch of code that checks the NSEventType, specifically looking for NSEventTypeBeginGesture or NSEventTypeEndGesture. Neither of these event types will be sent on 10.11 or later, so any code that looks for these types needs updating.
,
Feb 22 2017
Ping - what's your status here rohit?
,
Mar 13 2017
,
May 19 2017
I need to find a new owner for this.
,
Jul 11 2017
This is the main blocker for 10.12 SDK deployment. Dealing with it.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71535232c5bfac6324fd9ef74d132d647bfff24d commit 71535232c5bfac6324fd9ef74d132d647bfff24d Author: Erik Chen <erikchen@chromium.org> Date: Wed Jul 12 01:59:13 2017 Fix pinch-to-zoom when linking against the 10.11 SDK or newer. This CL is based on Rohit's CL at https://codereview.chromium.org/2682593005. When linking against the 10.11 SDK or newer, the OS will no longer directly call |beginGestureWithEvent:| or |endGestureWithEvent:|. Instead, applications must check the event's phase inside of |magnifyWithEvent:|. Earlier OS versions will still call the old methods, regardless of which SDK is used. This CL adds both compile-time and runtime checks to ensure that the "begin" and "end" helper methods are called exactly once per gesture. Bug: 680927 Change-Id: Ibb3fab854b28fba0f48ea766710c4aff7c066b19 Reviewed-on: https://chromium-review.googlesource.com/567241 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#485791} [modify] https://crrev.com/71535232c5bfac6324fd9ef74d132d647bfff24d/content/browser/renderer_host/input/synthetic_gesture_target_mac.mm [modify] https://crrev.com/71535232c5bfac6324fd9ef74d132d647bfff24d/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/71535232c5bfac6324fd9ef74d132d647bfff24d/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/71535232c5bfac6324fd9ef74d132d647bfff24d/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
,
Jul 13 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kbr@chromium.org
, Jan 13 2017