the "New incognito window" option in the right-click menu does not have the incognito icon
Reported by
billdill...@gmail.com,
Jan 13 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: when you right-click on Chrome in the taskbar (or also the Chrome live tile in the start screen or the apps list in Windows 10) there menu that pops up does not have the incognito icon for the "New incognito window" option, it's just using the normal Chrome icon. Edge and Firefox rightly use a different icon for their respective private mode option and Chrome should too. I've attached a screenshot comparing Edge, Firefox and Chrome What is the expected behavior? What went wrong? see above Did this work before? N/A Chrome version: 55.0.2883.87 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 24.0 r0
,
Jan 20 2017
Sounds reasonable to me. +sabineb@ WDYT?
,
Jan 20 2017
,
Jan 23 2017
A nice little thing about this on Windows 10 (I can't check on Windows 7 or 8 so I don't know) is that the right-click menu is black, so the incognito icon will look good and more familiar/recognizable there compared to the Android image above
,
Jan 24 2017
+rhalavati, do you have resource to look into this?
,
Jan 25 2017
Yes, I will look into it.
,
Jan 26 2017
,
Feb 21 2017
Uploaded black and white versions of the incognito icon at 256, 48, 32, and 16px. https://drive.google.com/open?id=0BxMIIGI80eU-S24yTDdsUFQ3WEk
,
Feb 22 2017
Adding to my previous message, the current icon is white incognito sign on transparent background. May be it should be white on black circle so that if someone chooses a light theme, it would be sill visible.
,
Feb 24 2017
Asked for new icon with circular dark background and light incognito sign.
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/596cbc2cc875076c361b1b77e840919a2697b67d commit 596cbc2cc875076c361b1b77e840919a2697b67d Author: rhalavati <rhalavati@chromium.org> Date: Wed Mar 15 08:22:49 2017 Incognito icon added to Windows taskbar jumplist. On Windows' taskbar's jumplist, both "New window" and "New incognito window" links have main Chrome icon. A rough Incognito icon is added to the repository and used instead of Chrome icon for new incognito window link. BUG= 680904 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2660153002 Cr-Commit-Position: refs/heads/master@{#457032} [modify] https://crrev.com/596cbc2cc875076c361b1b77e840919a2697b67d/chrome/app/chrome_exe.rc [add] https://crrev.com/596cbc2cc875076c361b1b77e840919a2697b67d/chrome/app/theme/chromium/win/incognito.ico [modify] https://crrev.com/596cbc2cc875076c361b1b77e840919a2697b67d/chrome/browser/win/jumplist.cc [modify] https://crrev.com/596cbc2cc875076c361b1b77e840919a2697b67d/chrome/common/chrome_icon_resources_win.cc [modify] https://crrev.com/596cbc2cc875076c361b1b77e840919a2697b67d/chrome/common/chrome_icon_resources_win.h
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33d538d5169ba8ff274c6cccc9985679bb75746a commit 33d538d5169ba8ff274c6cccc9985679bb75746a Author: tzik <tzik@chromium.org> Date: Wed Mar 15 08:59:57 2017 Revert of Incognito icon added to Windows taskbar jumplist. (patchset #7 id:120001 of https://codereview.chromium.org/2660153002/ ) Reason for revert: This CL causes a build failure on a bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/16181 The error log was: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Win%2F16181%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout FAILED: obj/chrome/chrome_initial/chrome_exe.res ../../chrome/app/chrome_exe.rc(60) : error RC2135 : file not found: theme\google_chrome\win\incognito.ico Original issue's description: > Incognito icon added to Windows taskbar jumplist. > > On Windows' taskbar's jumplist, both "New window" and "New incognito window" links have main Chrome icon. > A rough Incognito icon is added to the repository and used instead of Chrome icon for new incognito window link. > > BUG= 680904 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > > Review-Url: https://codereview.chromium.org/2660153002 > Cr-Commit-Position: refs/heads/master@{#457032} > Committed: https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840919a2697b67d TBR=grt@chromium.org,elawrence@chromium.org,bettes@chromium.org,sky@chromium.org,maxwalker@chromium.org,rhalavati@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 680904 Review-Url: https://codereview.chromium.org/2752593004 Cr-Commit-Position: refs/heads/master@{#457037} [modify] https://crrev.com/33d538d5169ba8ff274c6cccc9985679bb75746a/chrome/app/chrome_exe.rc [delete] https://crrev.com/bcf3cc76c4dd7e474e6c458fcd5a8d288a6000f4/chrome/app/theme/chromium/win/incognito.ico [modify] https://crrev.com/33d538d5169ba8ff274c6cccc9985679bb75746a/chrome/browser/win/jumplist.cc [modify] https://crrev.com/33d538d5169ba8ff274c6cccc9985679bb75746a/chrome/common/chrome_icon_resources_win.cc [modify] https://crrev.com/33d538d5169ba8ff274c6cccc9985679bb75746a/chrome/common/chrome_icon_resources_win.h
,
Mar 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/866370b6e17ade289f4f7f2731390bc0d4661423 commit 866370b6e17ade289f4f7f2731390bc0d4661423 Author: Ramin Halavati <rhalavati@google.com> Date: Wed Mar 15 10:46:17 2017
,
Mar 15 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/866370b6e17ade289f4f7f2731390bc0d4661423 commit 866370b6e17ade289f4f7f2731390bc0d4661423 Author: Ramin Halavati <rhalavati@google.com> Date: Wed Mar 15 10:46:17 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50800dc9e40ad2a4aebd4503dad70b46086a4f6f commit 50800dc9e40ad2a4aebd4503dad70b46086a4f6f Author: rhalavati <rhalavati@chromium.org> Date: Thu Mar 16 13:35:35 2017 Incognito icon added to Windows taskbar jumplist. On Windows' taskbar's jumplist, both "New window" and "New incognito window" links have main Chrome icon. An Incognito icon is added to the repository and used instead of Chrome icon for new incognito window link. BUG= 680904 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2660153002 Cr-Commit-Position: refs/heads/master@{#457032} Committed: https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840919a2697b67d patch from issue 2660153002 at patchset 120001 (http://crrev.com/2660153002#ps120001) In the previous attempt to land the CL, I had not updated the DEPS file of src-internal with the new icon and it broke the build. Now the icon is added to Google Chrome by this CL: https://chromereviews.googleplex.com/573787013/ And DEPS file is updated in this CL: https://chromereviews.googleplex.com/569457014/ TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2750023002 Cr-Commit-Position: refs/heads/master@{#457417} [modify] https://crrev.com/50800dc9e40ad2a4aebd4503dad70b46086a4f6f/chrome/app/chrome_exe.rc [add] https://crrev.com/50800dc9e40ad2a4aebd4503dad70b46086a4f6f/chrome/app/theme/chromium/win/incognito.ico [modify] https://crrev.com/50800dc9e40ad2a4aebd4503dad70b46086a4f6f/chrome/browser/win/jumplist.cc [modify] https://crrev.com/50800dc9e40ad2a4aebd4503dad70b46086a4f6f/chrome/common/chrome_icon_resources_win.cc [modify] https://crrev.com/50800dc9e40ad2a4aebd4503dad70b46086a4f6f/chrome/common/chrome_icon_resources_win.h
,
Mar 16 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kkaluri@chromium.org
, Jan 16 2017Labels: M-57
Status: Untriaged (was: Unconfirmed)
1.2 MB
1.2 MB View Download