New issue
Advanced search Search tips

Issue 680903 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 665468



Sign in to add a comment

Fail to unmount a volume with large images while generating thumbnails

Project Member Reported by yamaguchi@chromium.org, Jan 13 2017

Issue description

Chrome Version: 57.0.2980.0
Chrome OS Platform: any

Steps To Reproduce:
(1) Create a zip file with a large number of large image files.
(2) Store it to the Downloads folder
(3) Open it. See Files app open the mounted volume.
(4) While the image thumbnails are appearing, click the eject button of the mounted zip file on the left pane.

Expected Result:
Unmount succeeds.

Actual Result:
Sometimes get error message telling not to remove the device and retry unmounting, because there's existing operation.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Sometimes.

What is the impact to the user, and is there a workaround? If so, what is
it?
There is a workaround. User can retry several times, or try after all the thumbnails are loaded.



This is likely to be caused by the Files app starting to load thumbnails automatically but not cancelling it when the eject icon is clicked.
 

Comment 1 by fukino@chromium.org, Mar 22 2017

Status: Available (was: Untriaged)
Blocking: 665468

Comment 3 by sashab@chromium.org, Feb 23 2018

Labels: CrOS-FilesApp-Zip

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Zip CrOSFilesFeature-Zip
Owner: amistry@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bff4aef1e478c93d04a96d74f6ad38a9a1f43db

commit 0bff4aef1e478c93d04a96d74f6ad38a9a1f43db
Author: Anand K. Mistry <amistry@chromium.org>
Date: Thu Aug 23 06:03:43 2018

Use lazy unmount for read-only mount points.

A lazy unmount detaches the mount point immediately. Existing file
accesses will continue, but any new accesses will fail. For read-only
mounts, we do this because there are no changes to sync back to the
volume and therefore it is ok if the volume is removed without waiting
for the unmount.

Note, this doesn't take into account the safety of removing media that
should be "safely removed", such as hard disks.

BUG= 789562 , 680903 

Change-Id: I4dca06f825d5f3b4012bafa9a43e05bfe6455d23
Reviewed-on: https://chromium-review.googlesource.com/1184645
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585410}
[modify] https://crrev.com/0bff4aef1e478c93d04a96d74f6ad38a9a1f43db/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/0bff4aef1e478c93d04a96d74f6ad38a9a1f43db/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
[modify] https://crrev.com/0bff4aef1e478c93d04a96d74f6ad38a9a1f43db/chrome/test/data/extensions/api_test/file_browser/mount_test/test.js

Status: Fixed (was: Assigned)

Sign in to add a comment