New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 680892 link

Starred by 1 user
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
█ scottchen@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Arrow icon button is not displayed after entering long data in People section.

Reported by dmascare...@etouch.net, Jan 13 2017 
Chrome Version:57.0.2980.0 (Official Build) 6770bab14919fc9abed1d457387824e84cc43602-refs/heads/master@{#443474}
OS:Windows(7,8,8.1,10),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1 Launch chrome,sign in to chrome with valid credential and navigate to chrome://md-settings/manageProfile,enter long profile name
2 Click on back arrow and observe.
3.Press 'Shift+Tab' such that focus reaches to 'Sign out' and then again press 'Shift+Tab', Observe

Actual: 1.Arrow icon button is not displayed after entering long data in People section.
        2.After step 3, Arrow icon is seen but the Profile name goes behind the profile image.

Expected: 1.Arrow icon button should be displayed after entering long data in People section.
          2.After step 3,Profile name text should seen properly.

This is a regression issue broken in 'M57' and below is manual regression range:
Good Build: 57.0.2979.0
Bad Build:  57.0.2980.0
Actual_profilename.mp4
961 KB View Download

Comment 1 by hdodda@chromium.org, Jan 13 2017

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2979.0 (revision : 443120)
Bad build: 57.0.2980.0 (revision : 443474)

You are probably looking for a change made after 443279 (known good), but no later than 443280 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
 
https://chromium.googlesource.com/chromium/src/+log/f38ee194e671002a245a2a2c0c52cc7b0a762da1..5e234b7e88e8a8f0c48de5713460fe600d510e72

From the CL above, assigning the issue to the concern owner 

@scottchen- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2629483002

Thanks!

Comment 2 by scottchen@chromium.org, Jan 13 2017

Status: Started (was: Assigned)
It's related - when I fixed it such that it wouldn't push the "sign out" button out of view, I didn't notice that there's an arrow button there and is still getting pushed out. 

Will look into a fix now.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8ff90663001db32c1cdbfb0df0c79dadb16d353

commit b8ff90663001db32c1cdbfb0df0c79dadb16d353
Author: scottchen <scottchen@chromium.org>
Date: Sat Jan 21 02:57:58 2017

MD Settings: on people page, fix long names breaking arrow icon

Long text inside a flex-child doesn't work properly with (text-)overflow due to min-width of a flex-child defaulting to the length of the content. A reasonably proper fix was found to be setting "min-width:0" on the flex-child to override this behavior, so that texts inside the flex-child are forced to ellipse.

BUG= 680893 ,  680892 ,  680918 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2638983002
Cr-Commit-Position: refs/heads/master@{#445257}

[modify] https://crrev.com/b8ff90663001db32c1cdbfb0df0c79dadb16d353/chrome/browser/resources/settings/people_page/people_page.html

Comment 4 by scottchen@chromium.org, Jan 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment