Issue metadata
Sign in to add a comment
|
Feature Request: Make Nacl/Chrome Apps use GpuMemoryBuffers for output |
||||||||||||||||||||
Issue descriptionWe would like to make some full screen apps on ChromeOS devices make use of overlay support in order to reduce the display latency. This is only possible if we make the app use GpuMemoryBuffers for output.
,
Jan 14 2017
These two CLs make this work on Kevin: https://codereview.chromium.org/2632903002 https://chromium-review.googlesource.com/428550 However, with the current limited support for direct scanout only for fullscreen buffers the benefit is limited. E.g. Keep drawing app will never be fullscreen as the toolbar at the top is not part of the Pepper3D output. We either need generic HW overlay support or make the Pepper3D output of the app fullscreen for this to provide a performance benefit.
,
Jan 17 2017
adlr - is there any chance of making the Pepper3D output for the app full screen?
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b288ced458b070ee2785301c4600d65806362557 commit b288ced458b070ee2785301c4600d65806362557 Author: reveman <reveman@chromium.org> Date: Thu Jan 19 00:26:10 2017 gpu: Pepper3DImageChromium support on ChromeOS. This adds support for Pepper3DImageChromium feature on ChromeOS. The feature is disabled by default but can be enabled on devices with support for RGBA8888 native GpuMemoryBuffers. This allows HW overlays to be used for Pepper3D output. BUG= 680851 TEST=chrome --enable-features=Pepper3DImageChromium CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2632903002 Cr-Commit-Position: refs/heads/master@{#444563} [modify] https://crrev.com/b288ced458b070ee2785301c4600d65806362557/content/public/common/content_features.cc [modify] https://crrev.com/b288ced458b070ee2785301c4600d65806362557/content/renderer/pepper/ppb_graphics_3d_impl.cc [modify] https://crrev.com/b288ced458b070ee2785301c4600d65806362557/content/renderer/pepper/ppb_graphics_3d_impl.h [modify] https://crrev.com/b288ced458b070ee2785301c4600d65806362557/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/b288ced458b070ee2785301c4600d65806362557/gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc [modify] https://crrev.com/b288ced458b070ee2785301c4600d65806362557/gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.h
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/17058fe0c9b0367a5e5b2e188f0d0b233c5e9dae commit 17058fe0c9b0367a5e5b2e188f0d0b233c5e9dae Author: David Reveman <reveman@chromium.org> Date: Sat Jan 14 22:26:12 2017 login: Enable GLImage output for Pepper3D on kevin. Makes it possible to use HW overlays for output. BUG= chromium:680851 TEST=emerge-kevin chromeos-base/chromeos-login Change-Id: I7c379d3311fdf81a68e6c05e0da43da80f1cba18 Reviewed-on: https://chromium-review.googlesource.com/428550 Commit-Ready: David Reveman <reveman@chromium.org> Tested-by: David Reveman <reveman@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/17058fe0c9b0367a5e5b2e188f0d0b233c5e9dae/login_manager/chrome_setup.cc
,
Jan 19 2017
,
Feb 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3aa2f5150aa815142dc94c8a3e8ab52f1ec23573 commit 3aa2f5150aa815142dc94c8a3e8ab52f1ec23573 Author: Daniele Castagna <dcastagna@chromium.org> Date: Wed Feb 01 19:17:56 2017 gpu: Correct GMB format for GL_RGB BackTexture. When allocating a GMB for the offscreen color texture we should pick the correct GMB format based on the internalformat of the fb. We used to always allocate RGBA, with this patch we'll allocate RGBX in case the internal foramt is GL_RGB. BUG= 680851 ,chrome-os-partner:62472 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2665963002 Cr-Commit-Position: refs/heads/master@{#447340} (cherry picked from commit 5a771c396bea52c449c4e22a15b93973f60488e0) Review-Url: https://codereview.chromium.org/2671523002 . Cr-Commit-Position: refs/branch-heads/2987@{#250} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/3aa2f5150aa815142dc94c8a3e8ab52f1ec23573/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0024a8f99b5f5ec02f194eda8ceee2eaaba276cd commit 0024a8f99b5f5ec02f194eda8ceee2eaaba276cd Author: David Reveman <reveman@chromium.org> Date: Tue Mar 14 02:58:53 2017 Revert "login: Enable GLImage output for Pepper3D on kevin." This reverts commit 17058fe0c9b0367a5e5b2e188f0d0b233c5e9dae. Reason for revert: Black video screen display while playing facebook game Original change's description: > login: Enable GLImage output for Pepper3D on kevin. > > Makes it possible to use HW overlays for output. > > BUG= chromium:680851 > TEST=emerge-kevin chromeos-base/chromeos-login > > Change-Id: I7c379d3311fdf81a68e6c05e0da43da80f1cba18 > Reviewed-on: https://chromium-review.googlesource.com/428550 > Commit-Ready: David Reveman <reveman@chromium.org> > Tested-by: David Reveman <reveman@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > TBR=derat@chromium.org,reveman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG= chromium:680851 BUG=chromium:699802 Change-Id: I9f99da8d11281ed90bd46e1f7ea309879b4c50bc Reviewed-on: https://chromium-review.googlesource.com/453003 Commit-Ready: David Reveman <reveman@chromium.org> Tested-by: David Reveman <reveman@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/0024a8f99b5f5ec02f194eda8ceee2eaaba276cd/login_manager/chrome_setup.cc
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c84c73395de0718ced82bbbfa4ee65c13ba229cf commit c84c73395de0718ced82bbbfa4ee65c13ba229cf Author: David Reveman <reveman@chromium.org> Date: Tue Mar 14 16:12:23 2017 Revert "login: Enable GLImage output for Pepper3D on kevin." This reverts commit 17058fe0c9b0367a5e5b2e188f0d0b233c5e9dae. Reason for revert: Black video screen display while playing facebook game Original change's description: > login: Enable GLImage output for Pepper3D on kevin. > > Makes it possible to use HW overlays for output. > > BUG= chromium:680851 > TEST=emerge-kevin chromeos-base/chromeos-login > > Change-Id: I7c379d3311fdf81a68e6c05e0da43da80f1cba18 > Reviewed-on: https://chromium-review.googlesource.com/428550 > Commit-Ready: David Reveman <reveman@chromium.org> > Tested-by: David Reveman <reveman@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > TBR=derat@chromium.org,reveman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG= chromium:680851 BUG=chromium:699802 Change-Id: I9f99da8d11281ed90bd46e1f7ea309879b4c50bc Reviewed-on: https://chromium-review.googlesource.com/453003 Commit-Ready: David Reveman <reveman@chromium.org> Tested-by: David Reveman <reveman@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> (cherry picked from commit 0024a8f99b5f5ec02f194eda8ceee2eaaba276cd) Reviewed-on: https://chromium-review.googlesource.com/454301 Commit-Queue: David Reveman <reveman@chromium.org> Trybot-Ready: David Reveman <reveman@chromium.org> [modify] https://crrev.com/c84c73395de0718ced82bbbfa4ee65c13ba229cf/login_manager/chrome_setup.cc
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/554ec0df8efd584711629edcc4fae1e3ac35e2dd commit 554ec0df8efd584711629edcc4fae1e3ac35e2dd Author: David Reveman <reveman@chromium.org> Date: Tue Mar 14 22:48:10 2017 Revert "login: Enable GLImage output for Pepper3D on kevin." This reverts commit 17058fe0c9b0367a5e5b2e188f0d0b233c5e9dae. Reason for revert: Black video screen display while playing facebook game Original change's description: > login: Enable GLImage output for Pepper3D on kevin. > > Makes it possible to use HW overlays for output. > > BUG= chromium:680851 > TEST=emerge-kevin chromeos-base/chromeos-login > > Change-Id: I7c379d3311fdf81a68e6c05e0da43da80f1cba18 > Reviewed-on: https://chromium-review.googlesource.com/428550 > Commit-Ready: David Reveman <reveman@chromium.org> > Tested-by: David Reveman <reveman@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > TBR=derat@chromium.org,reveman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG= chromium:680851 BUG=chromium:699802 Change-Id: I9f99da8d11281ed90bd46e1f7ea309879b4c50bc Reviewed-on: https://chromium-review.googlesource.com/453003 Commit-Ready: David Reveman <reveman@chromium.org> Tested-by: David Reveman <reveman@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> (cherry picked from commit 0024a8f99b5f5ec02f194eda8ceee2eaaba276cd) Reviewed-on: https://chromium-review.googlesource.com/455396 Commit-Queue: David Reveman <reveman@chromium.org> Trybot-Ready: David Reveman <reveman@chromium.org> [modify] https://crrev.com/554ec0df8efd584711629edcc4fae1e3ac35e2dd/login_manager/chrome_setup.cc
,
Apr 17 2017
,
May 30 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f36920f8a01eb8ad3a0e891cd401627cd74ed3af commit f36920f8a01eb8ad3a0e891cd401627cd74ed3af Author: David Reveman <reveman@chromium.org> Date: Thu Jun 22 21:58:30 2017 gpu: Fix texture target for Pepper3DImageChromium on ChromeOS. Use GL_TEXTURE_2D instead of GL_TEXTURE_EXTERNAL_OES with GMBs when texture is used as a target for drawing. GL_TEXTURE_EXTERNAL_OES should only be used when the buffer is only used for sampling. This is also consistent with the buffer queue that is using GL_TEXTURE_2D. BUG= 680851 TEST=chrome --enable-features=Pepper3DImageChromium Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0e0ab013a474eaaaf6af10c79c7dd4e98a4351d1 Reviewed-on: https://chromium-review.googlesource.com/544236 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#481680} [modify] https://crrev.com/f36920f8a01eb8ad3a0e891cd401627cd74ed3af/content/renderer/pepper/ppb_graphics_3d_impl.cc [modify] https://crrev.com/f36920f8a01eb8ad3a0e891cd401627cd74ed3af/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/634c0ad14297b08c83ac0e147b7675bf993a2d68 commit 634c0ad14297b08c83ac0e147b7675bf993a2d68 Author: David Reveman <reveman@chromium.org> Date: Wed Jun 28 21:45:12 2017 Reland "login: Enable GLImage output for Pepper3D on kevin." This is a reland of 17058fe0c9b0367a5e5b2e188f0d0b233c5e9dae The reason for the previous revert was fixed by https://chromium-review.googlesource.com/c/544236/ and Chrome 61.0.3142.0 and later should not have that issue. Original change's description: > login: Enable GLImage output for Pepper3D on kevin. > > Makes it possible to use HW overlays for output. > > BUG= chromium:680851 > TEST=emerge-kevin chromeos-base/chromeos-login > > Change-Id: I7c379d3311fdf81a68e6c05e0da43da80f1cba18 > Reviewed-on: https://chromium-review.googlesource.com/428550 > Commit-Ready: David Reveman <reveman@chromium.org> > Tested-by: David Reveman <reveman@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> Bug: chromium:680851 Change-Id: I6668ca1137ba09394a561cf866b3eea13900040d Reviewed-on: https://chromium-review.googlesource.com/552342 Commit-Ready: David Reveman <reveman@chromium.org> Tested-by: David Reveman <reveman@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> [modify] https://crrev.com/634c0ad14297b08c83ac0e147b7675bf993a2d68/login_manager/chrome_setup.cc
,
Aug 1 2017
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5b73b0139e1b065902ba751610210b6322c827f commit b5b73b0139e1b065902ba751610210b6322c827f Author: David Reveman <reveman@chromium.org> Date: Tue Aug 08 00:52:04 2017 gpu: Use BGRX format for GMB back textures. This format is preferred on ozone as it is required to be supported on all devices. BUG= 680851 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0af2fae182107151831cd8b463d3685d15e0caae Reviewed-on: https://chromium-review.googlesource.com/602789 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#492477} [modify] https://crrev.com/b5b73b0139e1b065902ba751610210b6322c827f/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Aug 10 2017
Requesting merge of change in #16. This is needed on Intel devices that use drm atomics for Pepper 3D apps that use alpha=0 to work.
,
Aug 10 2017
The bug is marked as P3 or Feature. It should not be merged as M61 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10 2017
,
Aug 10 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73e83f0c15b25abf8ead9553c2dd935fec2119e3 commit 73e83f0c15b25abf8ead9553c2dd935fec2119e3 Author: David Reveman <reveman@chromium.org> Date: Thu Aug 10 19:46:26 2017 gpu: Use BGRX format for GMB back textures. This format is preferred on ozone as it is required to be supported on all devices. BUG= 680851 TBR=reveman@chromium.org (cherry picked from commit b5b73b0139e1b065902ba751610210b6322c827f) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0af2fae182107151831cd8b463d3685d15e0caae Reviewed-on: https://chromium-review.googlesource.com/602789 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492477} Reviewed-on: https://chromium-review.googlesource.com/611027 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#452} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/73e83f0c15b25abf8ead9553c2dd935fec2119e3/gpu/command_buffer/service/gles2_cmd_decoder.cc
,
Aug 10 2017
,
Oct 14 2017
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af065264b854c79be26f94751624a39d6839ce44 commit af065264b854c79be26f94751624a39d6839ce44 Author: Fritz Koenig <frkoenig@google.com> Date: Mon Jul 02 22:51:49 2018 gpu: rename FramebufferParameter FramebufferAttachmentParameter better describes the group of parameters. FramebufferParameter will be reused later for FramebufferParameteri parameters. BUG= 680851 Change-Id: I01ffbc5783163460b5ff54d8c7d1e5de044e333a Reviewed-on: https://chromium-review.googlesource.com/1117364 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#572030} [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/build_gles2_cmd_buffer.py [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/client/gles2_implementation_impl_autogen.h [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/common/gles2_cmd_utils_autogen.h [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/gles2_cmd_buffer_functions.txt [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/service/feature_info.cc [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/service/feature_info_unittest.cc [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/service/gles2_cmd_validation_autogen.h [modify] https://crrev.com/af065264b854c79be26f94751624a39d6839ce44/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51ad9a0f7c64429061c98373a6b1625f1750c359 commit 51ad9a0f7c64429061c98373a6b1625f1750c359 Author: Fritz Koenig <frkoenig@google.com> Date: Mon Jul 23 23:37:32 2018 gpu: Invert geometry vertically for GMB backed offscreen contexts. Push mesa to invert the framebuffer if the GL_MESA_framebuffer_flip_y extension is available. BUG= 680851 Change-Id: Ib22dfb1d03fcc54acc016de29bdead16398ef416 Reviewed-on: https://chromium-review.googlesource.com/1091917 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577323} [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/GLES2/gl2chromium_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/build_gles2_cmd_buffer.py [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_c_lib_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_cmd_helper_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_implementation_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_implementation_impl_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_implementation_unittest_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_interface_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_interface_stub_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_trace_implementation_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/common/capabilities.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/common/gles2_cmd_format_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/common/gles2_cmd_ids_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/common/gles2_cmd_utils_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/gles2_cmd_buffer_functions.txt [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/feature_info.cc [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/feature_info.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/feature_info_unittest.cc [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/gles2_cmd_validation_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/third_party/khronos/GLES2/gl2ext.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/generate_bindings.py [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_bindings.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_bindings_api_autogen_gl.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_bindings_autogen_gl.cc [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_bindings_autogen_gl.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_bindings_autogen_mock.cc [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_bindings_autogen_mock.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_enums_implementation_autogen.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_mock_autogen_gl.h [modify] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gl/gl_stub_autogen_gl.h
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1958f5d0cac3d99e3ee212ec10a98b958ee52e25 commit 1958f5d0cac3d99e3ee212ec10a98b958ee52e25 Author: Fritz Koenig <frkoenig@google.com> Date: Tue Jul 24 01:35:49 2018 blink: Use OpenGL to flip WebGL buffer GL_FRAMEBUFFER_FLIP_Y_MESA will tell OpenGL to render the image upside down. Passing the buffer along like this will allow ChromeOS to scan out directly from the buffer. BUG= 680851 Change-Id: I142cec041358af17652f7314ac89e82678b78d3b Reviewed-on: https://chromium-review.googlesource.com/1117365 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577396} [modify] https://crrev.com/1958f5d0cac3d99e3ee212ec10a98b958ee52e25/gpu/ipc/common/gpu_command_buffer_traits_multi.h [modify] https://crrev.com/1958f5d0cac3d99e3ee212ec10a98b958ee52e25/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc [modify] https://crrev.com/1958f5d0cac3d99e3ee212ec10a98b958ee52e25/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h
,
Aug 17
#27 This patch breaks rendering of Sketchfab in 70 on ChromeOS (say Lars with Intel GPU). The image is upside down.
,
Aug 17
#28 do you think your issue is related to https://bugs.chromium.org/p/chromium/issues/detail?id=872845 ? |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by reve...@chromium.org
, Jan 14 2017