New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680845 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 681641
Owner:
OOO until 2019-01-24
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

webgl2_conformance_tests on Mac-10.12 Intel GPU

Project Member Reported by fjhenigman@chromium.org, Jan 13 2017

Issue description

Since the switch from 10.10 to 10.12 here:
https://codereview.chromium.org/2627553002

We have these failures on Mac GPU ASAN Release
webgl2_conformance_tests on Intel GPU on Mac on Mac-10.12
failures:
WebglConformance_conformance_more_functions_copyTexImage2D
WebglConformance_deqp_functional_gles3_texturespecification_basic_copyteximage2d
WebglConformance_deqp_functional_gles3_negativetextureapi
WebglConformance_conformance_more_functions_copyTexSubImage2D

e.g.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20GPU%20ASAN%20Release/builds/1262

This bot seems flaky, but the above issue seems consistent.
 

Comment 1 by kbr@chromium.org, Jan 13 2017

Cc: zmo@chromium.org
Components: Internals>GPU>Testing Blink>WebGL
Status: Started (was: Untriaged)
We need to add support for ASAN-specific test expectations.

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c61df25bec9534e4393a744babaebd46be64e4bd

commit c61df25bec9534e4393a744babaebd46be64e4bd
Author: kbr <kbr@chromium.org>
Date: Fri Jan 13 20:43:26 2017

Add support for ASAN-specific test expectations to WebGL tests.

Because each test harness will need to explicitly add code to handle
ASAN expectations, add the command-line flag only to the WebGL harness
for now.

Pass the appropriate command line argument on the Mac ASAN bot. Added
unit tests for the new functionality.

Fixed a preexisting bug with capitalization of test expectations.
Added tests for it.

BUG= 680845 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2632603002
Cr-Commit-Position: refs/heads/master@{#443655}

[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/content/test/gpu/gpu_tests/gpu_test_expectations.py
[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/content/test/gpu/gpu_tests/test_expectations.py
[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/content/test/gpu/gpu_tests/test_expectations_unittest.py
[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py
[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
[modify] https://crrev.com/c61df25bec9534e4393a744babaebd46be64e4bd/testing/buildbot/chromium.gpu.fyi.json

Comment 3 by kbr@chromium.org, Jan 13 2017

Status: Fixed (was: Started)
I'm going to call this fixed rather than leaving it open indefinitely. I don't know if we're going to be able to track down these ASAN-only test failures.

Mergedinto: 681641
Status: Duplicate (was: Fixed)

Sign in to add a comment