Issue metadata
Sign in to add a comment
|
|webkit-patch pretty-diff| doesn't work |
||||||||||||||||||||||
Issue descriptionChrome Version: ToT OS: macOS 10.11 What steps will reproduce the problem? (1) Checkout Chromium (2) Update files (3) Run "third_party/WebKit/Tools/Scripts/webkit-patch pretty-diff" What is the expected result? A browser shows a diff. What happens instead? ----------------------- % webkit-patch pretty-diff PrettyPatch failed. :( Failed to run "['git', 'git', 'diff', '-r', '--name-status', '--no-renames', '--no-ext-diff', '--full-index', u'26ff4b57824280ec42599a7c92fcacadfe5201f3']" exit_code: 1 cwd: /Users/kent/chrome/src output: git: 'git' is not a git command. See 'git --help'. Did you mean this? init --------------------- Please use labels and text to provide additional information. This is a recent regression (in this week?)
,
Jan 13 2017
,
Jan 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d097cd3bbd127ea8168b7d399ab25404b9701b15 commit d097cd3bbd127ea8168b7d399ab25404b9701b15 Author: qyearsley <qyearsley@chromium.org> Date: Mon Jan 16 00:19:46 2017 Follow-up fix to Git module. After http://crrev.com/2594513003, the git.changed_files function was broken, which broke webkit-patch pretty-diff. BUG= 676012 , 680839 Review-Url: https://codereview.chromium.org/2636453005 Cr-Commit-Position: refs/heads/master@{#443824} [modify] https://crrev.com/d097cd3bbd127ea8168b7d399ab25404b9701b15/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
,
Jan 16 2017
Thank you for the fix! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Jan 13 2017Status: Assigned (was: Untriaged)