New issue
Advanced search Search tips

Issue 680832 link

Starred by 2 users
Status: Fixed
Owner:
paulmeyer@chromium.org
Closed: Jan 10
Cc:
rbyers@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Deprecated APIs not using DeprecateMessageSource

Project Member Reported by ericbidelman@chromium.org, Jan 13 2017 
We're attempting to use the `Log.entryAdded` event in Lighthouse to log deprecated
API usage. 

So far, I've caught a few inconsistencies:

- CSS /deep/ and ::shadow do not provide .url or .lineNumber

- MediaStreamTrack.getSources(); // does not trigger a Log.entryAdded with source: 'deprecation'

- console.timeline(); // does not trigger a Log.entryAdded with source: 'deprecation'

There are probably other deprecated APIs not using DeprecateMessageSource. Would be good to do an audit and add them everywhere.

Comment 1 by pfeldman@chromium.org, Jan 13 2017

Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Untriaged)
@kozyatinskiy: could you follow up with the v8-related fix?

Comment 2 by rbyers@chromium.org, Jan 14 2017

Cc: foolip@chromium.org rbyers@chromium.org
Components: Blink>Infra>Predictability
Thanks for working on this!

I thought that almost all deprecations were using the Deprecations class which has a single spot that the console message is added, but I can believe there are a couple special cases.

Comment 3 by ericbidelman@chromium.org, Feb 9 2017 

Found another one. If you use geolocation on an http site, the console warns:

getCurrentPosition() and watchPosition() no longer work on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.
(anonymous) @ VM1299:1


But this does not surface in our Lighthouse audit for deprecated messages. Should it? It's not really a deprecation or intervention, but a new policy as of Chrome 50.

Comment 4 by rbyers@chromium.org, Mar 29 2017

Cc: juliatut...@chromium.org
Yeah technically "deprecation" messages are really just warnings about things that will go away in the future.  Generally we can't/don't retain warnings once an API has been removed.  This geolocation one is more the "interventions" use case.  I'd argue we should be using "InterventionMessageSource" for that one.

Comment 5 by cha...@chromium.org, Sep 12 2017

Components: -Blink>Infra>Predictability Internals>FeatureControl

Comment 6 by kozyatinskiy@chromium.org, Oct 16 2017

Owner: kozy@chromium.org

Comment 7 by iclell...@chromium.org, May 3 2018 

Hi Kozy -- has there been any progress on this?

Comment 8 by cha...@chromium.org, Dec 14

Cc: -juliatut...@chromium.org
Owner: paulmeyer@chromium.org
Status: Available (was: Assigned)
Paul, had done a sweep to get all deprecation messages using the centralized Deprecations class. Did that cover the specific examples in this old bug. If so, I think we can safely close.

Comment 9 by paulmeyer@chromium.org, Jan 10

Status: Fixed (was: Available)
This has been fixed by the new deprecation structure implemented for Reporting API.
►

Sign in to add a comment