Offline pages do not download when chrome is in background. |
||||||
Issue description(this may be related to crbug.com/677365) repro steps: Start a tip of tree build of chrome on an android device Go into airplane mode type a URL, hit enter we get a dino page. My team's cool button to save the page for later appears. Press the save page later button. Go to the home screen (so chrome is in the background) Come out of airplane mode. When I do this, GCMNM should notify chrome to wake up and download the page as requested. We do wake up, but when our code checks NetworkChangeNotifier, the type is still 6 (CONNECTION_NONE). Since the GCMNM code comes into the Java code, I can call the android APIs to detect connectivity, and they report the device is connected over wifi. I then call the java side NetworkChangeNotifier code, which reports CONNECTION_NONE. We can work around this for now by relying on the connection type from Android, but NetworkChangeNotifier may also need a fix.
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87501749a54ab7879f4233e15a4fdb9b0f6adc46 commit 87501749a54ab7879f4233e15a4fdb9b0f6adc46 Author: petewil <petewil@chromium.org> Date: Tue Jan 17 20:25:32 2017 style Workaround NetworkConnectionManager race condition Sometimes when GCM NetworkManager fires, Chromium doesn't yet know that we have a connection, and reports the current connection type as CONNECTION_NONE, even though android reports that we have a connection. If we find a time when NetworkConnectionManager says there is no connection, but android says there is a connection, send a valid connection type down to the request coordinator, so it can start downloading a file. We need to merge this to M56. BUG= 680831 Review-Url: https://codereview.chromium.org/2632573002 Cr-Commit-Position: refs/heads/master@{#444121} [modify] https://crrev.com/87501749a54ab7879f4233e15a4fdb9b0f6adc46/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
,
Jan 17 2017
This fixes an important break to the offline pages feature. May we please merge this change into M56?
,
Jan 17 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18 2017
,
Jan 20 2017
Merge approved for M56 branch 2924.
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28216f1cdf9cce15ba59140c789676ae05f9b353 commit 28216f1cdf9cce15ba59140c789676ae05f9b353 Author: Pete Williamson <petewil@chromium.org> Date: Fri Jan 20 00:51:46 2017 Workaround NetworkConnectionManager race condition Sometimes when GCM NetworkManager fires, Chromium doesn't yet know that we have a connection, and reports the current connection type as CONNECTION_NONE, even though android reports that we have a connection. If we find a time when NetworkConnectionManager says there is no connection, but android says there is a connection, send a valid connection type down to the request coordinator, so it can start downloading a file. We need to merge this to M56. BUG= 680831 Review-Url: https://codereview.chromium.org/2632573002 Cr-Commit-Position: refs/heads/master@{#444121} (cherry picked from commit 87501749a54ab7879f4233e15a4fdb9b0f6adc46) Review-Url: https://codereview.chromium.org/2648683002 . Cr-Commit-Position: refs/branch-heads/2924@{#811} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/28216f1cdf9cce15ba59140c789676ae05f9b353/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
,
Jan 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by petewil@chromium.org
, Jan 13 2017