New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680802 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-30
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 543161



Sign in to add a comment

malware_subresource interstitial shows more on V4 than V3

Project Member Reported by nparker@chromium.org, Jan 13 2017

Issue description

A theory in last week's meeting was that this is due to incorrect handling of metadata, which is supposed to cause the interstitial to not show in some cases.
 

Comment 1 by vakh@chromium.org, Jan 13 2017

Status: Started (was: Assigned)

Comment 2 by vakh@chromium.org, Jan 13 2017

Blocking: 543161

Comment 3 by vakh@chromium.org, Jan 13 2017

Labels: SafeBrowsing-Triaged

Comment 4 Deleted

Comment 5 by vakh@chromium.org, Jan 13 2017

Blocked on http://b/34282788

Comment 7 by vakh@chromium.org, Jan 24 2017

Status: Started (was: ExternalDependency)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d7499da3e2579015a187268d58863f713eec33e

commit 0d7499da3e2579015a187268d58863f713eec33e
Author: vakh <vakh@chromium.org>
Date: Wed Jan 25 01:15:47 2017

XS: s/malware_pattern_type/malware_threat_type

BUG= 680802 

Review-Url: https://codereview.chromium.org/2642823013
Cr-Commit-Position: refs/heads/master@{#445894}

[modify] https://crrev.com/0d7499da3e2579015a187268d58863f713eec33e/components/safe_browsing_db/v4_get_hash_protocol_manager.cc

Comment 9 by vakh@chromium.org, Jan 25 2017

NextAction: 2017-01-27

Comment 10 by vakh@chromium.org, Jan 27 2017

NextAction: 2017-01-30
The number of these interstitials is still higher for PVer4. I have pinged on the internal CL to see if it is in production yet. Will check status again on Monday.

Comment 11 by vakh@chromium.org, Jan 30 2017

The 1-day aggregation data for 1/28 shows that the number of malware subresource interstitials have dropped. Still can't see the data aggregated for 7 days. See: b/34811290

Comment 12 by vakh@chromium.org, Jan 31 2017

1/26: https://uma.googleplex.com/p/chrome/variations/escape_hatch.html?sid=2b8dd2a6e0f40a6f2c77089e052dec74
The problem shows high number of interstitials for V4Only2 (vs Control2) for interstitial.malware_subresource.decision

1/27: https://uma.googleplex.com/p/chrome/variations/escape_hatch.html?sid=63566b5e4f5edb7a4d9658963cee38a6
Similar number for interstitial.malware_subresource.decision for Control2 and V4Only2

1/28: https://uma.googleplex.com/p/chrome/variations/escape_hatch.html?sid=a9e08fde14e243b1b109be275058578a
Similar number for interstitial.malware_subresource.decision for Control2 and V4Only2

1/29: https://uma.googleplex.com/p/chrome/variations/escape_hatch.html?sid=ca5f2c92198d0123336e5ffc931c6172
Similar number for interstitial.malware_subresource.decision for Control2 and V4Only2

This makes me think this has been fixed in Canary.
nparker@ -- WDYT?
Yes, LGTM!

Comment 14 by vakh@chromium.org, Jan 31 2017

Status: Fixed (was: Started)

Sign in to add a comment