New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 680787 link

Starred by 1 user
Status: Fixed
Owner:
█ baxley@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
eugene...@chromium.org
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Make custom EarlGrey matchers match Chromium style

Project Member Reported by baxley@chromium.org, Jan 12 2017 
Most of the custom EarlGrey matchers are C-style methods, but start with a lowercase letter. This was done to match EarlGrey style, which is in violation.

We should clean this up and make all of our custom matchers compliant with the Chromium style guide.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68f208ca4c5dc605c04bd468746e00cb66140849

commit 68f208ca4c5dc605c04bd468746e00cb66140849
Author: baxley <baxley@chromium.org>
Date: Tue Jan 24 23:58:16 2017

Make EarlGrey matchers compliant with Chromium style.

EarlGrey matchers are C-style, but they start with a lowercase
letter. Our custom matchers started lowercase, so this CL
brings our custom matchers in compliance with Chromium style, while
making it inconsistent with EarlGrey.

BUG= 680787 

Review-Url: https://codereview.chromium.org/2642193012
Cr-Commit-Position: refs/heads/master@{#445867}

[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/autofill/form_input_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/context_menu/context_menu_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/metrics/BUILD.gn
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/translate/translate_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/browser_view_controller_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/error_page_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/first_run/first_run_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/fullscreen_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/history/tab_history_popup_controller_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/infobars/infobar_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/keyboard_commands_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/print/print_controller_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/settings/block_popups_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/settings/translate_ui_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/ui/webui/web_ui_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/browsing_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/browsing_prevent_default_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/child_window_open_by_dom_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/forms_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/http_auth_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/js_print_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/navigation_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/progress_indicator_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/stop_loading_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/visible_url_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/browser/web/window_open_by_dom_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/test/earl_grey/chrome_matchers.h
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/test/earl_grey/chrome_matchers.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/test/earl_grey/device_check_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/chrome/test/earl_grey/smoke_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/testing/earl_grey/matchers.h
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/testing/earl_grey/matchers.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/public/test/earl_grey/web_view_actions.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/public/test/earl_grey/web_view_matchers.h
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/public/test/earl_grey/web_view_matchers.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/context_menu_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/earl_grey/shell_base_test_case.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/earl_grey/shell_matchers.h
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/earl_grey/shell_matchers.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/meta_tags_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/navigation_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/page_state_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/pdf_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/plugin_placeholder_egtest.mm
[modify] https://crrev.com/68f208ca4c5dc605c04bd468746e00cb66140849/ios/web/shell/test/redirect_egtest.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/088977979f2bb20beb6215cbb09e8951b83a9b4c

commit 088977979f2bb20beb6215cbb09e8951b83a9b4c
Author: baxley <baxley@google.com>
Date: Wed Jan 25 01:40:19 2017

Comment 3 by baxley@chromium.org, Mar 23 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bc7717c1d7ccf5a90464a3fdf38536fd24d7fa8

commit 1bc7717c1d7ccf5a90464a3fdf38536fd24d7fa8
Author: baxley <baxley@chromium.org>
Date: Fri Mar 24 01:03:40 2017

Fix style of custom matcher in settings_egtest.mm.

EarlGrey matchers are C-Style methods and should start with a
capital letter in Chromium.

BUG= 680787 

Review-Url: https://codereview.chromium.org/2777453002
Cr-Commit-Position: refs/heads/master@{#459315}

[modify] https://crrev.com/1bc7717c1d7ccf5a90464a3fdf38536fd24d7fa8/ios/chrome/browser/ui/settings/settings_egtest.mm

Comment 5 by baxley@chromium.org, Mar 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment