New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680784 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug
Team-Security-UX


Participants' hotlists:
Security-UX-Consistency


Sign in to add a comment

iOS Material Page Info (Interim)

Project Member Reported by lgar...@chromium.org, Jan 12 2017

Issue description

See attachment for Max's mocks.

We're going for option B, except we don't have colored summaries on any platforms yet (and it would be extra work to implement on iOS).

I will also preserve issuer name for non-broken HTTPS, as well as listing bullet points for certificate issues. Since iOS doesn't have connection/certificate details (Issue 502470), this is needed to avoid a regression.
 
iOS Interim.png
310 KB View Download
Emily, how do these look?
expired.png
155 KB View Download
mixed.png
154 KB View Download
http-login.png
134 KB View Download
secure.png
146 KB View Download
http-tablet.png
199 KB View Download
Cc: maxwalker@chromium.org
So the idea is that we will remove that last paragraph, as soon as we implement a cert viewer, and there's no ETA on that right now.

That sounds reasonable -- at the very least, this is a clear improvement over the current state.
Cc: mard...@chromium.org
also cc +mardini, to make sure this plan SGTY
> So the idea is that we will remove that last paragraph, as soon as we implement a cert viewer, and there's no ETA on that right now.

Yes, except... cert viewer is probably never going to happen with WKWebView. :-/
If we get Page Info in a more consistent state across platforms and want to avoid the extra paragraph on iOS, I suggest we shuffle it paragraph into a secondary "Details" popup like on Android.
Cc: eugene...@chromium.org rohitrao@chromium.org
+ Eugene, Rohit (FYI)

Thanks for the heads-up. I agree this is a clear improvement over the current state.
Lucas, why do you think that cert viewer on iOS is not possible? Is it because iOS uses SecTrust API for cert verification?
Yeah, I had the impression that it wasn't possible now. If that's wrong, it would be great to implement!
So what do we need to implement this? iOS provides API to get cert chain, which can be used to create X509Certificate. Is that sufficient to implement cert viewer?
Yep, that would be sufficient. The Android viewer is pretty simple, and parity with that would be useful.
Let's continue at Issue 502470?
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6dd3781121d6a697d9d525e9d965f38c72b8df0

commit a6dd3781121d6a697d9d525e9d965f38c72b8df0
Author: lgarron <lgarron@chromium.org>
Date: Fri Jan 20 01:23:58 2017

Update Page Info on iOS to an interim Material Design state.

This brings it mostly in sync with other platforms by replacing two sections (identity info and connection info) with a single section containing a security summary and a sentence with details about what the security state means.

This CL also:
- Drops logic to show error strings related to and SHA-1 deprecation, since we don't detail this on desktop and some of these states can't even be detected on WKWebView anymore.
- Preserves the layout code for multiple sections, even if we only show a single one now.
- Preserves certificate information for devs/power users, since there is no other way to get the info until we have a certificate viewer on iOS (crbug.com/502470).

BUG= 680784 ,  656843 ,  640478 
TEST=Visit the following sites and check against the screenshots at  crbug.com/680784#c1  :
- expired.badssl.com (on iPhone)
- mixed.badssl.com (on iPhone)
- http-login.badssl.com (on iPhone)
- www.google.com (on iPhone)
- http.badssl.com (on iPad)

Review-Url: https://codereview.chromium.org/2620243005
Cr-Commit-Position: refs/heads/master@{#444919}

[modify] https://crrev.com/a6dd3781121d6a697d9d525e9d965f38c72b8df0/ios/chrome/browser/ui/omnibox/page_info_model.cc

Labels: M-57
Status: Fixed (was: Started)
Cc: pinkerton@chromium.org stuartmorgan@chromium.org f...@chromium.org egm@chromium.org pkl@chromium.org lgar...@chromium.org
 Issue 457767  has been merged into this issue.

Sign in to add a comment