Issue metadata
Sign in to add a comment
|
9.3% regression in memory.top_10_mobile_stress at 442957:443031 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 12 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8990629805795923344
,
Jan 13 2017
=== Auto-CCing suspected CL author ericrk@chromium.org === Hi ericrk@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : ericrk Commit : 916f273d2383cfca5c75a930793f096b1b5677ca Date : Wed Jan 11 22:18:33 2017 Subject: Remove ShallowFlushCHROMIUM after resource deletion Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : memory.top_10_mobile_stress Metric : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/foreground/https_mobile_twitter_com_justinbieber_skip_interstitial_true Change : 11.65% | 219664384.0 -> 245250730.667 Revision Result N chromium@442957 219664384 +- 483259 6 good chromium@442994 222197077 +- 14329132 6 good chromium@443004 220091733 +- 2848942 6 good chromium@443009 219653461 +- 562650 6 good chromium@443010 222717952 +- 13946398 6 good chromium@443011 245430955 +- 468403 6 bad <-- chromium@443013 245261653 +- 573986 6 bad chromium@443031 245250731 +- 542242 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https.mobile.twitter.com.justinbieber.skip.interstitial.true memory.top_10_mobile_stress Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8990629805795923344 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5283441538498560 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jan 13 2017
,
Jan 13 2017
Investigating
,
Jan 20 2017
,
Jan 23 2017
The change here is reverting previous logic which was incorrectly committed (https://chromium.googlesource.com/chromium/src/+/da59d418f54604ba2451cd0ef3a9cd42c05ca530). The previous logic did save us memory, but at a large performance cost (and was not intended for commit). This change never made it to a release branch, so the revert here shouldn't have an impact on the overall release to release memory tracking.
,
Mar 14 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by benjhayden@chromium.org
, Jan 12 2017