Disable app banners in incognito |
||||
Issue descriptionApp banners are currently shown in incognito, while the add to homescreen menu item is disabled. This inconsistency should be fixed by also preventing banners from being shown when in incognito.
,
Jan 17 2017
(in progress, see http://crrev.com/2633603002)
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cc0b4685ce52aac20f0c42b4938be23bd462872 commit 8cc0b4685ce52aac20f0c42b4938be23bd462872 Author: dominickn <dominickn@chromium.org> Date: Wed Jan 18 01:21:28 2017 Disable app banners in incognito. The add to homescreen menu item is disabled in incognito mode. For consistency, this CL disables app banners when a site is opened in incognito. Browser tests and instrumentation tests are added to ensure the correct functionality. BUG= 680778 Review-Url: https://codereview.chromium.org/2633603002 Cr-Commit-Position: refs/heads/master@{#444223} [modify] https://crrev.com/8cc0b4685ce52aac20f0c42b4938be23bd462872/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java [modify] https://crrev.com/8cc0b4685ce52aac20f0c42b4938be23bd462872/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/8cc0b4685ce52aac20f0c42b4938be23bd462872/chrome/browser/banners/app_banner_manager_browsertest.cc [modify] https://crrev.com/8cc0b4685ce52aac20f0c42b4938be23bd462872/chrome/browser/banners/app_banner_metrics.cc [modify] https://crrev.com/8cc0b4685ce52aac20f0c42b4938be23bd462872/chrome/browser/installable/installable_logging.cc [modify] https://crrev.com/8cc0b4685ce52aac20f0c42b4938be23bd462872/chrome/browser/installable/installable_logging.h [modify] https://crrev.com/8cc0b4685ce52aac20f0c42b4938be23bd462872/tools/metrics/histograms/histograms.xml
,
Jan 18 2017
,
Jan 24 2017
Verified in 57.0.2987.8
,
Feb 6 2017
,
Feb 16 2017
Issue 691128 has been merged into this issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 by sbirch@chromium.org
, Jan 13 2017