New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680776 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

smoothness.gpu_rasterization_and_decoding.image_decoding_cases failing on 9 builders

Project Member Reported by oysteine@chromium.org, Jan 12 2017

Issue description

Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 13 2017


=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : smoothness.gpu_rasterization_and_decoding.image_decoding_cases
  Metric       : frame_time_discrepancy/yuv_decoding.html

Revision             Exit Code      N
chromium@442978      1 +- N/A       5      good
chromium@443077      1 +- N/A       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=yuv.decoding.html smoothness.gpu_rasterization_and_decoding.image_decoding_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8990629720983004880

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5777137560190976


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jan 13 2017

Cc: zakerinasab@chromium.org
Owner: zakerinasab@chromium.org

=== Auto-CCing suspected CL author zakerinasab@chromium.org ===

Hi zakerinasab@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : zakerinasab
  Commit : 7fb9535883e50ab0d7262ea8a0e8470934e57a9c
  Date   : Wed Jan 11 19:09:13 2017
  Subject: Implement color management for ImageData

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : smoothness.gpu_rasterization_and_decoding.image_decoding_cases
  Metric       : mean_frame_time/mean_frame_time

Revision             Exit Code      N
chromium@442949      0 +- N/A       20      good
chromium@442965      0 +- N/A       20      good
chromium@442970      0 +- N/A       20      good
chromium@442972      0 +- N/A       20      good
chromium@442973      1 +- N/A       20      bad       <--
chromium@442974      1 +- N/A       20      bad
chromium@442980      1 +- N/A       20      bad
chromium@443009      1 +- N/A       20      bad
chromium@443069      1 +- N/A       20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.gpu_rasterization_and_decoding.image_decoding_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8990621933743790368

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5573113862946816


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
I created a revert in https://codereview.chromium.org/2636533002/
Cc: jochen@chromium.org junov@chromium.org
The patch would not revert cleanly. zakerinasab: can you please take a look? This is causing lots of perf waterfall failures on Windows.
Cc: pam@chromium.org amineer@chromium.org
+pam, amineer: This is another stability-related issue. It's really unclear in the logs what happened: chrome just stops running, but we can't find a callstack.

https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_10_High-DPI_Perf%2F189%2F%2B%2Frecipes%2Fsteps%2Fsmoothness.gpu_rasterization_and_decoding.image_decoding_cases_on_Intel_GPU_on_Windows_on_Windows-10-10240%2F0%2Fstdout
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_10_Perf%2F258%2F%2B%2Frecipes%2Fsteps%2Fsmoothness.gpu_rasterization_and_decoding.image_decoding_cases_on__102b__GPU_on_Windows_on_Windows-10-10240%2F0%2Fstdout

(In this case we're able to bisect and see that it starts with the CL above, but if this happens flakily we are out of luck)
I'm looking into it. If a quick fix was not possible, I'll create a manual revert and land it for now.
Thanks!

Note that if you're unable to repro, the same hardware/OS configs are available on perf try bots: https://www.chromium.org/developers/telemetry/performance-try-bots
Status: Fixed (was: Available)
The issue has been fixed and the respective CL was landed again (https://codereview.chromium.org/2555213002/) at commit position 443939. None of the mentioned perf bots report failing on smoothness.gpu_rasterization_and_decoding.image_decoding_cases performance test. So I set the status of this bug as fixed.

Sign in to add a comment