New issue
Advanced search Search tips

Issue 680770 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"TextureLayerImplWithMailboxThreadedCallback.RunMultiThread_DelegatingRenderer" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 12 2017

Issue description

"TextureLayerImplWithMailboxThreadedCallback.RunMultiThread_DelegatingRenderer" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWAsSBUZsYWtlIk1UZXh0dXJlTGF5ZXJJbXBsV2l0aE1haWxib3hUaHJlYWRlZENhbGxiYWNrLlJ1bk11bHRpVGhyZWFkX0RlbGVnYXRpbmdSZW5kZXJlcgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by xlai@chromium.org, Jan 13 2017

Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
ericrk@: I saw that you recently touched texture_layer_unittest.cc. Can you look into this flaky unit test? If it is not related to your change, please help triage this bug to the appropriate owner; thanks!

Comment 2 by ericrk@chromium.org, Jan 13 2017

Cc: ericrk@chromium.org
 Issue 681093  has been merged into this issue.

Comment 3 by ericrk@chromium.org, Jan 13 2017

Reverting the change in question until I sort this out.

Comment 4 by vmp...@chromium.org, Jan 13 2017

Cc: danakj@chromium.org piman@chromium.org vmp...@chromium.org enne@chromium.org
FWIW, there's  crbug.com/638368  which was filed a while back. It seems that the test is flaky, but this change might exaggerate this 

Comment 5 by vmp...@chromium.org, Jan 13 2017

Currently it seems to fail about 50% of the time.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b443521bc4bc46b4bd1537910f089fbf1578273

commit 4b443521bc4bc46b4bd1537910f089fbf1578273
Author: ericrk <ericrk@chromium.org>
Date: Fri Jan 13 22:54:24 2017

Revert of Remove ForceReclaimResources (patchset #8 id:170001 of https://codereview.chromium.org/2609253003/ )

Reason for revert:
This has introduced flakiness into TextureLayerImplWithMailboxThreadedCallback.RunMultiThread_DelegatingRenderer, will address this and re-land.

Original issue's description:
> Remove ForceReclaimResources
>
> We had previously added ForceReclaimResources to BeginCommit to throttle
> frame output and prevent starving the display compositor's rasterization
> tasks. Unfortunately, this introduces significant overhead as well.
>
> With the addition of the Display Scheduler, this change no longer
> appears to be needed. The scheduler has independent controls for
> limiting the number of pending frames, and these should be used instead
> (if further tweaking is necessary).
>
> Removing this logic does not regress the benchmarks which it was
> initially added for, and seems unneeded at this point. Removing.
>
> R=reveman@chromium.org
> BUG=676852,489515, 617268 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2609253003
> Cr-Commit-Position: refs/heads/master@{#443061}
> Committed: https://chromium.googlesource.com/chromium/src/+/dc1892fc0639464d4418ccfaedfd1f95a5b947d0

TBR=reveman@chromium.org,danakj@chromium.org,enne@chromium.org,tommi@chromium.org,brianderson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=676852,489515, 617268 ,  681093 ,  680770 

Review-Url: https://codereview.chromium.org/2633563003
Cr-Commit-Position: refs/heads/master@{#443709}

[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/output/compositor_frame_sink.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/direct_compositor_frame_sink_unittest.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface_factory.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/surfaces/surface_factory.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/layer_tree_test.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_pixeltest_tiles.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/content/test/layouttest_support.cc
[modify] https://crrev.com/4b443521bc4bc46b4bd1537910f089fbf1578273/ui/compositor/layer_unittest.cc

Comment 7 by meade@chromium.org, Jan 17 2017

Labels: -Sheriff-Chromium
Removing from sheriff queue since the CL was reverted.

Comment 8 by meade@chromium.org, Jan 17 2017

FYI it seems like there is a low level of flakiness in this test even without this CL.

Comment 9 by ericrk@chromium.org, Jan 25 2017

 Issue 638368  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad5923814efe7dc0c236c7894955e3b696d73cd9

commit ad5923814efe7dc0c236c7894955e3b696d73cd9
Author: ericrk <ericrk@chromium.org>
Date: Wed Jan 25 23:26:12 2017

Fix flakiness in TextureLayerImplWithMailboxThreadedCallback

We used to rely on callbacks happening within one frame. Nothing
guaranteed this. This change updates the logic so that progress in the
test is driven by the callback.

R=danakj@chromium.org
BUG= 680770 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2651283002
Cr-Commit-Position: refs/heads/master@{#446162}

[modify] https://crrev.com/ad5923814efe7dc0c236c7894955e3b696d73cd9/cc/layers/texture_layer_unittest.cc

Status: Fixed (was: Assigned)
This should be resolved now.

Sign in to add a comment