New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 680768 link

Starred by 1 user
Status: WontFix
Owner:
qyears...@chromium.org
Closed: Jan 2017
Cc:
█ sashab@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Rebaseline of layout tests doesn't work for all tests

Project Member Reported by ktyliu@chromium.org, Jan 12 2017 
Hi Quinten,

Can I ask you about issues for rebaseline layout tests?

I had a patch (http://crrev.com/2608423002) that require rebaseline of over a hundred test expectations, and `third_party/WebKit/Tools/Scripts/webkit-patch rebaseline-cl` works in updating most of the expectations.

However, 3 tests continued to fail after multiple tries of rebaseline-cl, so we used NeedsRebaseline in TestExpectations to unblock commit. After commit, auto-rebaseline (http://crrev.com/2628173002) then happened but that didn't work. Only "win" results are updated in that auto-rebaseline and caused the test for Mac 10.9 to fail.

Both the above patches have been reverted for now and we hope to reland soon (crrev.com/2626973005).

Do you have time to help take a look at our problem?

Thanks,
Kevin

Comment 1 by qyears...@chromium.org, Jan 13 2017 

Good question -- looking at that CL, I can't see why, although maybe I can try to reproduce (experimental copy CL for reproducing: https://codereview.chromium.org/2628213004).

(Meanwhile, I agree that making another CL with NeedsManualRebaseline and then focusing on those few tests which rebaseline-cl is failing to rebaseline is a good idea)

Comment 2 by qyears...@chromium.org, Jan 13 2017

Status: Assigned (was: Untriaged)
Summary: Rebaseline of layout tests doesn't work for all tests (was: Rebaseline of layouttest doesn't work for all tests)

Comment 3 by qyears...@chromium.org, Jan 14 2017 

Well, I didn't have much luck today finding an issue; I tried to reproduce the problem (https://codereview.chromium.org/2628213004) but after running rebaseline-cl once, the rebaseline seemed to succeed.

Let me know what happens with the follow-up to http://crrev.com/2626973005 rebaselining the remaining tests.

Comment 4 by ktyliu@chromium.org, Jan 15 2017 

Thanks for taking a look.
Okay let me try to get 2626973005 landed and hope the follow-up rebaseline
would work like your CL.

Comment 5 by ktyliu@chromium.org, Jan 18 2017 

Actually when I try rebaseline 2626973005 now it does look like it's working!

If that CL can be successfully landed, we can probably close this issue then (unless we have further reproducible cases).

Comment 6 by qyears...@chromium.org, Jan 25 2017

Status: WontFix (was: Assigned)
Aye, let's close this for now, but file another issue if it doesn't work in the future :-)
►

Sign in to add a comment