New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680751 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 680616



Sign in to add a comment

CrOS: update modemmanager-next, libmbim, libqmi to newer upstream revision

Project Member Reported by benchan@chromium.org, Jan 12 2017

Issue description

modemmanager-next, libmbim, libqmi haven't been updated for almost two years. Quite a few bug fixes have been landed in upstream. We should update these packages to a newer upstream revision.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/modemmanager-next/+/609d7bbd5a19508fada29d177e20f77fe05f9ad2

commit 609d7bbd5a19508fada29d177e20f77fe05f9ad2
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 12 22:28:05 2017

Revert "CHROMIUM: Remove node name from introspection files"

This reverts commit 52fbe37e5d78011366eec0033d5374a0c8950f0e.

Instead of modifying those introspection XMLs directly in the
modemmanager-next git repository, we now patch them in the
modemmanager-next ebuild instead (CL:427389).

BUG= chromium:680751 
CQ-DEPEND=CL:427389
TEST=Tested the following:
1. Build modemmanager-next and shill with CL:427389 applied.
2. Verify that the root <node> in the introspection XML of each
   ModemManager object interface (i.e.
   /usr/share/dbus-1/interfaces/org.freedesktop.ModemManager1.*.xml)
   doesn't have the name="/" attribute.

Change-Id: I5740b995a9a86b3abab9569b1ef91d59ea3bb46c
Reviewed-on: https://chromium-review.googlesource.com/427390
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/609d7bbd5a19508fada29d177e20f77fe05f9ad2/introspection/org.freedesktop.ModemManager1.Modem.Modem3gpp.xml
[modify] https://crrev.com/609d7bbd5a19508fada29d177e20f77fe05f9ad2/introspection/org.freedesktop.ModemManager1.Modem.ModemCdma.xml
[modify] https://crrev.com/609d7bbd5a19508fada29d177e20f77fe05f9ad2/introspection/org.freedesktop.ModemManager1.Modem.xml
[modify] https://crrev.com/609d7bbd5a19508fada29d177e20f77fe05f9ad2/introspection/org.freedesktop.ModemManager1.Modem.Simple.xml
[modify] https://crrev.com/609d7bbd5a19508fada29d177e20f77fe05f9ad2/introspection/org.freedesktop.ModemManager1.Sim.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9428c79d64be91960a5c7eb41f4d0f3ede396ecb

commit 9428c79d64be91960a5c7eb41f4d0f3ede396ecb
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 12 22:22:02 2017

modemmanager-next: fix root node object paths in introspection XMLs

According to "Introspection Data Format" of the DBus specification,
revision 0.30, "Only the root <node> element can omit the node name, as
it's known to be the object that was introspected. If the root <node>
does have a name attribute, it must be an absolute object path. If child
<node> have object paths, they must be relative."

The introspection XMLs of ModemManager object interfaces specify
name="/" at their root <node>, which should be omitted instead as the
object paths aren't fixed.

CL:294115 removed the name="/" attribute from those root <node>s in
several ModemManager introspection XMLs in order to allow
chromeos-dbus-bindings to properly generate the DBus proxies for
ModemManager interfaces. Instead of modifying those introspection XMLs
directly in the modemmanager-next git repository, we patch them (all
org.freedesktop.ModemManager1.*.xml, but not
org.freedesktop.ModemManager1.xml) here instead, which helps minimize
the difference between the local modemmanager-next repository and the
upstream repository.

BUG= chromium:680751 
TEST=Tested the following:
1. Build modemmanager-next and shill with CL:294115 reverted.
2. Verify that the root <node> in the introspection XML of each
   ModemManager object interface (i.e.
   /usr/share/dbus-1/interfaces/org.freedesktop.ModemManager1.*.xml)
   doesn't have the name="/" attribute.

Change-Id: I8f61459973d3d2eca581865c0833144c297ac433
Reviewed-on: https://chromium-review.googlesource.com/427389
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9428c79d64be91960a5c7eb41f4d0f3ede396ecb/net-misc/modemmanager-next/modemmanager-next-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/e23e1b7a7f43bed3009103885419637ccaf87259

commit e23e1b7a7f43bed3009103885419637ccaf87259
Author: Ben Chan <benchan@chromium.org>
Date: Fri Jan 20 07:04:15 2017

virtual/libintl: upgrade package to 0-r2

This CL imports virtual/libintl 0-r2 from upstream Gentoo with
only the modification of setting KEYWORDS to "*".

BUG= chromium:680751 
TEST=Remote trybot runs on chromiumos-sdk and paladin builders.

Change-Id: Ie6842bd06e59f6ac0adb0f62a6f9ea82e1435899
Reviewed-on: https://chromium-review.googlesource.com/430323
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e23e1b7a7f43bed3009103885419637ccaf87259/virtual/libintl/metadata.xml
[delete] https://crrev.com/07a9602b212f31b2ab9e13bd1edfb84e23f6d7f8/virtual/libintl/libintl-0-r1.ebuild
[add] https://crrev.com/e23e1b7a7f43bed3009103885419637ccaf87259/virtual/libintl/libintl-0-r2.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/18a5d25fc748215e62be5197dd53f3b1572a3ce4

commit 18a5d25fc748215e62be5197dd53f3b1572a3ce4
Author: Ben Chan <benchan@chromium.org>
Date: Fri Jan 13 00:34:07 2017

sys-devel/gettext: upgrade package to 0.19.7

This CL imports sys-devel/gettext 0.19.7 from upstream Gentoo with only
the modification of setting KEYWORDS to "*".

BUG= chromium:680751 
TEST=Remote trybot runs on chromiumos-sdk and paladin builders.

Change-Id: Ifd370b6bc411e3ce1ebd55e03e2e56986d81cc32
Reviewed-on: https://chromium-review.googlesource.com/430324
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/e23e1b7a7f43bed3009103885419637ccaf87259/sys-devel/gettext/gettext-0.18.3.2.ebuild
[modify] https://crrev.com/18a5d25fc748215e62be5197dd53f3b1572a3ce4/sys-devel/gettext/Manifest
[add] https://crrev.com/18a5d25fc748215e62be5197dd53f3b1572a3ce4/sys-devel/gettext/gettext-0.19.7.ebuild
[delete] https://crrev.com/e23e1b7a7f43bed3009103885419637ccaf87259/sys-devel/gettext/files/gettext-0.18.1.1-uclibc-sched_param-def.patch
[add] https://crrev.com/18a5d25fc748215e62be5197dd53f3b1572a3ce4/metadata/md5-cache/sys-devel/gettext-0.19.7
[modify] https://crrev.com/18a5d25fc748215e62be5197dd53f3b1572a3ce4/sys-devel/gettext/metadata.xml
[delete] https://crrev.com/e23e1b7a7f43bed3009103885419637ccaf87259/metadata/md5-cache/sys-devel/gettext-0.18.3.2
[add] https://crrev.com/18a5d25fc748215e62be5197dd53f3b1572a3ce4/sys-devel/gettext/files/gettext-0.19.7-disable-libintl.patch

Blockedon: 680616
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/76d0792d7058922637127dd15355a6a23d00ecea

commit 76d0792d7058922637127dd15355a6a23d00ecea
Author: Ben Chan <benchan@chromium.org>
Date: Wed Feb 08 04:14:30 2017

net-libs/libqmi: add mbim-qmux support

libqmi 1.16.0 or later provides an `--enable-mbim-qmux' option during
configure to enable multiplexing QMI messages over a MBIM control device
for some modems that support such feature. This CL adds a 'mbim' USE
flag to conditionally enable/disable the mbim-qmux option in libqmi and
pull in the libmbim dependency.

BUG= chromium:680751 
TEST=`USE=mbim FEATURES=test emerge-$BOARD libqmi`
TEST=`USE=-mbim FEATURES=test emerge-$BOARD libqmi`

Change-Id: I7d56c1e5c01df5377a3e41079511fdc95153cace
Reviewed-on: https://chromium-review.googlesource.com/438821
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/76d0792d7058922637127dd15355a6a23d00ecea/net-libs/libqmi/libqmi-9999.ebuild

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment