New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680747 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove Physical Web notifications

Project Member Reported by cco3@chromium.org, Jan 12 2017

Issue description

We don't show any notifications anymore.  Let's remove all related code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53466abaf91e1fe99c116cb275b4643be65ebcf5

commit 53466abaf91e1fe99c116cb275b4643be65ebcf5
Author: cco3 <cco3@chromium.org>
Date: Tue Jan 24 19:53:31 2017

Remove Physical Web notifications

This change is a first pass in removing Physical Web notifications.
It's already the case that Physical Web notifications do not fire, but
this change removes the code path that would fire notifications.  There
is still more vestigial code that will be removed in later changes.

BUG= 680747 

Review-Url: https://codereview.chromium.org/2650793005
Cr-Commit-Position: refs/heads/master@{#445784}

[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/chrome/android/java/AndroidManifest.xml
[delete] https://crrev.com/38fe35ec2f13cd49b5b024668897fff650482fee/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ClearNotificationAlarmReceiver.java
[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java
[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/chrome/android/java_sources.gni
[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java
[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java
[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/tools/metrics/actions/actions.xml
[modify] https://crrev.com/53466abaf91e1fe99c116cb275b4643be65ebcf5/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/ef400e364ec50a22370bbe429fde394ac7337dac

commit ef400e364ec50a22370bbe429fde394ac7337dac
Author: Ian Christie <iankc@google.com>
Date: Tue Jan 24 19:44:14 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f872c9f20b0d823b06e565c6e818b0f071e0fa37

commit f872c9f20b0d823b06e565c6e818b0f071e0fa37
Author: iankc <iankc@google.com>
Date: Sat Feb 04 02:11:28 2017

Remove ListUrlsActivity

This change removes the ListUrlsActivity from clank, which was used
for notifications for physical-web. Because notifications have been
phased out, we are removing this code because it is no longer needed.

BUG= 680747 

Review-Url: https://codereview.chromium.org/2651553005
Cr-Commit-Position: refs/heads/master@{#448145}

[modify] https://crrev.com/f872c9f20b0d823b06e565c6e818b0f071e0fa37/chrome/android/java/AndroidManifest.xml
[delete] https://crrev.com/4eb5e9b236c7eb1fb015f69a34dc7890cc706979/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
[delete] https://crrev.com/4eb5e9b236c7eb1fb015f69a34dc7890cc706979/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyUrlsAdapter.java
[modify] https://crrev.com/f872c9f20b0d823b06e565c6e818b0f071e0fa37/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
[add] https://crrev.com/f872c9f20b0d823b06e565c6e818b0f071e0fa37/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java
[modify] https://crrev.com/f872c9f20b0d823b06e565c6e818b0f071e0fa37/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
[modify] https://crrev.com/f872c9f20b0d823b06e565c6e818b0f071e0fa37/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
[modify] https://crrev.com/f872c9f20b0d823b06e565c6e818b0f071e0fa37/chrome/android/java_sources.gni
[delete] https://crrev.com/4eb5e9b236c7eb1fb015f69a34dc7890cc706979/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java
[modify] https://crrev.com/f872c9f20b0d823b06e565c6e818b0f071e0fa37/tools/metrics/histograms/histograms.xml

Comment 4 by mmo...@chromium.org, Feb 14 2017

I think there is still some residual code which was related to Notifications -- but perhaps we can mark this as complete since Notifications themselves have been removed?

The other stuff I think is general refactoring / code health work we can tackle at some point.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 28 2017

Comment 6 by cco3@chromium.org, Mar 7 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9aec66ca15c3630dcaeff94a0ffdc3068c11baa

commit c9aec66ca15c3630dcaeff94a0ffdc3068c11baa
Author: cco3 <cco3@chromium.org>
Date: Thu Mar 23 18:16:21 2017

Remove Physical Web optin recording code

We used to locally record the number of times we showed an optin
notification in order to keep from doing this too many times.  Now
that we don't show notifications, this code is no longer needed.

BUG= 680747 

Review-Url: https://codereview.chromium.org/2759283003
Cr-Commit-Position: refs/heads/master@{#459148}

[modify] https://crrev.com/c9aec66ca15c3630dcaeff94a0ffdc3068c11baa/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java

Sign in to add a comment