New issue
Advanced search Search tips

Issue 680745 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Gradient background doesn't paint correctly

Project Member Reported by elawrence@chromium.org, Jan 12 2017

Issue description

Chrome Version: 57.0.2979.0 
OS: Windows 10

What steps will reproduce the problem?
(1) Visit http://ericlawrence.com/eric/ 
(2) (Optional) Refresh the page a few times

What is the expected result? Background has a smooth blue gradient from top to bottom

What happens instead? Background is striped into repeating blocks

 
badrender.png
110 KB View Download
Badrender2.png
250 KB View Download

Comment 1 by pdr@chromium.org, Jan 12 2017

Labels: -Pri-3 Needs-Bisect Pri-2
Status: Available (was: Untriaged)
Confirmed, it looks like we layout & paint the document+background at one size, then resize the document (as more content loads) but fail to re-draw the background image. Resizing the page does fix the image. Lets see if a bisect reveals anything.

Comment 2 by ajha@chromium.org, Jan 13 2017

Cc: ajha@chromium.org
Labels: -Type-Bug -Pri-2 -Needs-Bisect hasbisect-per-revision M-56 OS-Linux OS-Mac OS-Windows Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
Able to reproduce the issue on the latest canary(57.0.2979.0) and the latest beta(56.0.2924.59) on Windows-10, Mac OS 10.12.2 and Linux Ubuntu 14.04.

Regressed in M-56.

Last good build: 56.0.2909.0
First bad build: 56.0.2910.0

Changelog:
===========
https://chromium.googlesource.com/chromium/src/+log/ba9bb4378a0f6e4e725ae1b68ee6d602db425a6f..1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4

wangxianzhu@: Could you please take a look at this.

Thank you!
Reduced test case. We fail to invalidate the viewport with gradient background when its layout overflow changes. Now this should be handled in BoxPaintInvalidator. Will revert the CL first and then fix BoxPaintInvalidator and reapply the CL.
gradient.html
346 bytes View Download
Summary: Gradient background doesn't paint correctly (was: SVG gradient background doesn't paint correctly)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d25330043a055c1327f5abec3fc512376531cc93

commit d25330043a055c1327f5abec3fc512376531cc93
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Sat Jan 14 01:42:41 2017

Revert of Remove obsolete code that invalidates document element on LayoutView resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )

Reason for revert:
Caused  bug 680745 . Revert first and then work on the correct fix.

BUG= 680745 

Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG= 475115 
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}

TBR=chrishtr@chromium.org,trchen@chromium.org
BUG= 475115 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2634613002
Cr-Commit-Position: refs/heads/master@{#443764}

[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/border-radius-repaint-2-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/fixed-and-absolute-position-scrolled-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/scrolled-iframe-scrollbar-change-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-composited-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-generated-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-media-query-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-html-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-viewport-percent-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-2-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-8-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/d25330043a055c1327f5abec3fc512376531cc93/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bbe43192ccb51e01ae956f268a9db3732fd5dcd

commit 7bbe43192ccb51e01ae956f268a9db3732fd5dcd
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sat Jan 14 03:18:36 2017

Auto-rebaseline for r443764

https://chromium.googlesource.com/chromium/src/+/d25330043a055

BUG= 680745 
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2633813002 .
Cr-Commit-Position: refs/heads/master@{#443779}

[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-frameset-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[add] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[add] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/resize-iframe-text-expected.txt
[add] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/stable/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/resize-iframe-text-expected.txt
[add] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/resize-iframe-text-expected.txt
[add] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/platform/win/virtual/stable/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/virtual/stable/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/7bbe43192ccb51e01ae956f268a9db3732fd5dcd/third_party/WebKit/LayoutTests/virtual/stable/paint/invalidation/window-resize-percent-html-expected.txt

Labels: Merge-Request-56 ReleaseBlock-Stable
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 15 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: TE-Verified-57.0.2982.0 TE-Verified-M57
Verified the issue on windows 10, Mac 10.12.1 and Ubuntu 14.04 using chrome version #57.0.2982.0 as per comment #0.

Observed that background has a smooth blue gradient from top to bottom as expected. Hence, the fix is working as expected.

Attaching screenshot for reference.

Hence, adding the verified labels.

Thanks...!!

680745.JPG
159 KB View Download
This is a really large change and we're close to Stable.  Do we know how many users are impacted this?  I'd prefer to wait until M57.
Please ignore the change of layout tests. The real change is just in this file: https://codereview.chromium.org/2634613002/diff/310001/third_party/WebKit/Source/core/layout/LayoutView.cpp, which is small. It's safe because it just reverts back to the code running on M55 and the code added back has no conflict with new code after M55.

Sorry we don't have data about gradient background.
 
Labels: -Merge-Review-56 Merge-Approved-56
Yeah I'm worried it will break the tests in the M56 branch.  If you can verify that everything still passes with the revert, I'm fine with merging.  Tentatively approving this.
Sure. Thanks. I will make sure all blink unit tests passing, and no new layout tests failures.
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 20 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a83d3c6e6fcee35ef35f57164fc446e88014034

commit 0a83d3c6e6fcee35ef35f57164fc446e88014034
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Jan 20 18:41:21 2017

Revert of Remove obsolete code that invalidates document element on LayoutView resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )

Reason for revert:
Caused  bug 680745 . Revert first and then work on the correct fix.

Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG= 475115 
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}

TBR=chrishtr@chromium.org,trchen@chromium.org
BUG= 680745 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2643723009
Cr-Commit-Position: refs/branch-heads/2924@{#819}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/border-radius-repaint-2-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/fixed-and-absolute-position-scrolled-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/scrolled-iframe-scrollbar-change-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-composited-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-generated-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-media-query-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-viewport-percent-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-2-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-8-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/0a83d3c6e6fcee35ef35f57164fc446e88014034/third_party/WebKit/Source/core/layout/LayoutView.cpp

Labels: Needs-triage-Mobile
Components: -Blink>SVG
Status: Fixed (was: Assigned)
Cc: rbasuvula@chromium.org
Labels: TE-Verified-M56 TE-Verified-56.0.2924.76
Tested the issue on Windows-7, Ubuntu 14.04 and Mac OS 10.12 using chrome latest Beta M56-56.0.2924.76 by following steps mentioned in the original comment. Observed that background has a smooth blue gradient from top to bottom as expected.Hence adding TE-Verified label.
Please find the screen shot for reference.

Thank you!
680745.png
361 KB View Download
Labels: OS-Android
With respect to the label added: Needs-triage-Mobile, triaged the issue and below are the observations.

Able to reproduce the issue on Mobile device (Tablet and Handset) as per steps provided. Striped background is seen on reloading when in normal mode and using the option "Request Desktop Mode".

Devices Used:
=============
Device Nexus 7 Tablet
Chrome Version: 58.0.3000.3
Android version: 5.0.2/LRX22G

The striped background is seen once when the URL is reloaded for every two times either in Normal mode or Desktop Site. Attaching a screen shot for the issue.

Device: Moto G
Chrome Version: 58.0.3000.3
Android version: 6.0.0/MPB24

The striped background is seen once when the URL is reloaded for every four to five times either in Normal mode or Desktop Site.

Thank You.
680745.jpg
4.0 MB View Download
Status: Assigned (was: Fixed)
@wangxianzhu: the tester seems to say they can reproduce still.
Re #19: The screenshot in question shows the page *during load*. I can reproduce that behavior (striped lines) sometimes during load, but when the page *finishes loading* it repaints the background correctly as one smooth gradient.

Prior to the CL referenced in #14, the incorrectly painted background would persist *after* the load had completed. That no longer appears to happen.
Status: Fixed (was: Assigned)
The #18 issue is not a regression. Filed  bug 688596  for it.

Sign in to add a comment