New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680742 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Crosperf does not pin frequency correctly for Big Little Devices

Project Member Reported by manojgupta@chromium.org, Jan 12 2017

Issue description

Crosperf queries the top frequency of the cpu0 and uses this number to
pin the frequency for each cpu.

On Big.Little arm cores, this strategy does not work since the top frequncy of cpu0 may not match other cores.

e.g. On elm, cpu0 top frequency is 1.7GHz but cpu 2 and cpu3 can support 2GHz. However, crosperf also sets them to 1.7GHz instead of 2 GHz.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/4e25342bd03fc8f5df7e4e4fe33649de82526730

commit 4e25342bd03fc8f5df7e4e4fe33649de82526730
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Jan 14 00:05:45 2017

Fix frequency pinning on crosperf.

Crosperf was pinning frequency to maximum based on cpu0
information. This does not work as intended for arm
Big-Little cores. Instead do it for each cpu based on its
own information.

BUG= chromium:680742 
TEST=Tested on elm, kevin, falco, samus, peach_pit and veyron_jaq.

Change-Id: I77fc76d8f1e94563fe12b3555bf08511fdbfdc32
Reviewed-on: https://chromium-review.googlesource.com/428186
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/4e25342bd03fc8f5df7e4e4fe33649de82526730/crosperf/suite_runner.py
[modify] https://crrev.com/4e25342bd03fc8f5df7e4e4fe33649de82526730/crosperf/suite_runner_unittest.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/4e25342bd03fc8f5df7e4e4fe33649de82526730

commit 4e25342bd03fc8f5df7e4e4fe33649de82526730
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Jan 14 00:05:45 2017

Fix frequency pinning on crosperf.

Crosperf was pinning frequency to maximum based on cpu0
information. This does not work as intended for arm
Big-Little cores. Instead do it for each cpu based on its
own information.

BUG= chromium:680742 
TEST=Tested on elm, kevin, falco, samus, peach_pit and veyron_jaq.

Change-Id: I77fc76d8f1e94563fe12b3555bf08511fdbfdc32
Reviewed-on: https://chromium-review.googlesource.com/428186
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/4e25342bd03fc8f5df7e4e4fe33649de82526730/crosperf/suite_runner.py
[modify] https://crrev.com/4e25342bd03fc8f5df7e4e4fe33649de82526730/crosperf/suite_runner_unittest.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment