New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680722 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Refinement arrow layout is not correct for Answers in Suggest.

Project Member Reported by jdonnelly@chromium.org, Jan 12 2017

Issue description

The refinement arrow (aka suggest button) is not in the correct position for Answers in Suggest on iOS. See attached screenshot.
 
unnamed (1).jpg
61.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae261b81e2f534a606db83c6ef4a15f64237f90f

commit ae261b81e2f534a606db83c6ef4a15f64237f90f
Author: jdonnelly <jdonnelly@chromium.org>
Date: Fri Jan 13 14:52:30 2017

Fix the layout of the append button on Answers in Suggest.

The existing layout assumes a fixed height for suggestions in the
omnibox suggestion popup. This assumption is violated by Answers in
Suggest rows. The assumption relates to the horizontal layout. There's
no particular reason why a different horizontal layout might not be
chosen independent of the row height, so this change uses a constant
instead, initially set to the non-AiS height of the suggest rows.

Also, fix some terminology in this file, replacing left/right with
leading/trailing.

BUG= 680722 

Review-Url: https://codereview.chromium.org/2629723002
Cr-Commit-Position: refs/heads/master@{#443556}

[modify] https://crrev.com/ae261b81e2f534a606db83c6ef4a15f64237f90f/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h
[modify] https://crrev.com/ae261b81e2f534a606db83c6ef4a15f64237f90f/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
[modify] https://crrev.com/ae261b81e2f534a606db83c6ef4a15f64237f90f/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment