New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680687 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

0 != max_aspect_ratio_ in video_track_adapter.cc

Project Member Reported by ClusterFuzz, Jan 12 2017

Issue description

Cc: emir...@chromium.org mcasas@chromium.org
Components: Internals>Media>Video
Labels: Test-Predator-Wrong M-56
Could not find culprit CL using regression range, findit and code search. adding few developers who worked on file video_track_adapter.cc. 

Comment 2 by mcasas@chromium.org, Jan 12 2017

Components: -Internals>Media>Video Blink>MediaStream
Owner: perkj@chromium.org
perkj@ landed this code IIRC.

Comment 3 by perkj@chromium.org, Jan 13 2017

Cc: perkj@chromium.org
Owner: guidou@chromium.org
I am no longer actively working in Chrome. I was not immediately able to find what might have caused this from the regression range. 
Guidou, would you mind investigating or find a suitable owner? 

Seems like something changed related to how tracks are created/destroyed?  

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be3576dd35b1cd9da3e71ad8f00cea203d3fcbd5

commit be3576dd35b1cd9da3e71ad8f00cea203d3fcbd5
Author: guidou <guidou@chromium.org>
Date: Fri Jan 13 14:47:50 2017

Ignore invalid optional constraints with invalid aspect ratio.

Failing to do this may lead to a CHECK in some cases.

BUG= 680687 

Review-Url: https://codereview.chromium.org/2632633004
Cr-Commit-Position: refs/heads/master@{#443555}

[modify] https://crrev.com/be3576dd35b1cd9da3e71ad8f00cea203d3fcbd5/content/renderer/media/media_stream_video_source.cc
[modify] https://crrev.com/be3576dd35b1cd9da3e71ad8f00cea203d3fcbd5/content/renderer/media/media_stream_video_source_unittest.cc

Comment 5 by guidou@chromium.org, Jan 13 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 6 by ClusterFuzz, Jan 14 2017

ClusterFuzz has detected this issue as fixed in range 443512:443579.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5401277728292864

Fuzzer: inferno_twister
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  0 != max_aspect_ratio_ in video_track_adapter.cc
  content::VideoTrackAdapter::VideoFrameResolutionAdapter::VideoFrameResolutionAda
  content::VideoTrackAdapter::AddTrackOnIO
  
Sanitizer: address (ASAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=399917:399984
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=443512:443579

Minimized Testcase (20.28 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97WseyiOTRynlkTreA5NvgVHSJiTFVsHCQlTTpFWdCN315IpC6mJQzHIvCZoBTxy-fz6TVxegWUZjuW6zX80BWe2HEUix-RSuWzkUpdai7vFtbFZ01eQ3F8tvCVgFYxMj-XwScQnROhh9JfJfuOf74vYIEt76LXEQYy9lB0ubFnBdQE5sFWGxEZhLwy88chcMhgl1waXxfHn4LBYsqoABATsMV8Kvgii3HJ0dx6TAAHlTQYesO7jK9BGxqXpfQ_A_KItrq01vgSC-0KApoNcAYuztsUTZhOZhc8TM8Bcw_g295dxKdf01iola1sMmYxIX3icNK9dHO9BtQSOJlf55hQJcxiVsM1bRg2m9lmbFLotS1R4_q7nJJhKVdrSIKBIbLTu-bn0QNSVWWtwYKpcK0cvYiONg?testcase_id=5401277728292864

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment