It's already complicated enough. We need to add unit tests so that devs feel comfortable making more changes.
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/3f1c0a7d056715aad6429576153a37bec6d1ed1e commit 3f1c0a7d056715aad6429576153a37bec6d1ed1e Author: Andrew Bonventre <andybons@chromium.org> Date: Thu Jan 19 00:08:26 2017 Add skeleton for unit tests BUG= 680664 Change-Id: Ie3f588eb4eac66c9e7f4ceca98b3ce6a5364ddf5 Reviewed-on: https://chromium-review.googlesource.com/430332 Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/3f1c0a7d056715aad6429576153a37bec6d1ed1e/.gitignore [add] https://crrev.com/3f1c0a7d056715aad6429576153a37bec6d1ed1e/test/buildbucket_test.html [add] https://crrev.com/3f1c0a7d056715aad6429576153a37bec6d1ed1e/test/bower.json [add] https://crrev.com/3f1c0a7d056715aad6429576153a37bec6d1ed1e/wct.conf.json [add] https://crrev.com/3f1c0a7d056715aad6429576153a37bec6d1ed1e/test/index.html [modify] https://crrev.com/3f1c0a7d056715aad6429576153a37bec6d1ed1e/README.md [add] https://crrev.com/3f1c0a7d056715aad6429576153a37bec6d1ed1e/test/cr-buildbucket-view_test.html
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/6675a6a7dae3a36eef690466ffcc4a3953549166 commit 6675a6a7dae3a36eef690466ffcc4a3953549166 Author: Andrew Bonventre <andybons@chromium.org> Date: Wed Jan 25 02:27:01 2017 Add unit tests for buildbucket.js BUG= 680664 Change-Id: Ic91545b0041b75ba05ffb883c984057a21ed656c Reviewed-on: https://chromium-review.googlesource.com/431067 Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/6675a6a7dae3a36eef690466ffcc4a3953549166/src/main/resources/static/buildbucket.js [modify] https://crrev.com/6675a6a7dae3a36eef690466ffcc4a3953549166/test/buildbucket_test.html
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/c39883c28c004e1b58ff5925d6f72a4e5bb45fae commit c39883c28c004e1b58ff5925d6f72a4e5bb45fae Author: Andrew Bonventre <andybons@chromium.org> Date: Thu Apr 27 20:02:15 2017 Refresh auth token when it expires Also adds additional unit tests for untested components. Bug:662771 Bug:680664 Bug:692980 Change-Id: I3dc2ea87a73953a4b4692694d89e4636352d5bcb Reviewed-on: https://chromium-review.googlesource.com/486986 Reviewed-by: Aaron Gable <agable@chromium.org> [add] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-buildbucket-client.js [modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-tryjob-picker.js [modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/test/cr-buildbucket-view_test.html [modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-tryjob-picker.html [add] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-buildbucket-client.html [modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-buildbucket-view.html [add] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/test/cr-buildbucket-client_test.html [modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/test/index.html [modify] https://crrev.com/c39883c28c004e1b58ff5925d6f72a4e5bb45fae/src/main/resources/static/cr-buildbucket-view.js
Comment 1 by andyb...@chromium.org
, Jan 12 2017