New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680629 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mojo::Watcher is posting tasks when it could call OnHandleReady directly

Project Member Reported by jcivelli@chromium.org, Jan 12 2017

Issue description

The mojo::Connector created by the ChannelAssociatedGroupController (ipc_channelbootstrap.cc) has its watcher posts tasks (in Watcher::CallOnHandleReady) instead of calling it directly.
Since all happens on the IO thread, it should call directly.

It seems that Watcher::task_runner_ is a sequence task runner for the IO thread but not the same as the one returned by base::ThreadTaskRunnerHandle::Get() on the IO thread.

Changing Watcher::task_runner_ to base::ThreadTaskRunnerHandle::Get() caused some child processes to still post, so it would probably be a good idea to tag Watcher instances created from ChannelAssociatedGroupController as should_not_post and assert if they pos so we catch these unnecessary posts. 
 

Comment 1 by roc...@chromium.org, Jan 13 2017

I would like to find a better policy for deciding when to post vs not to post, and I agree it would be good to trigger a DCHECK when posting is unexpected by the consumer.

Comment 2 by roc...@chromium.org, May 29 2017

Cc: roc...@chromium.org
Components: Internals>Mojo
Owner: ----
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, May 29 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -roc...@chromium.org rockot@google.com
Status: WontFix (was: Untriaged)
AFAICT this stuff is WAI. Not sure if there was a bug fixed or if the original report was missing something.

Sign in to add a comment