mojo::Watcher is posting tasks when it could call OnHandleReady directly |
|||||
Issue descriptionThe mojo::Connector created by the ChannelAssociatedGroupController (ipc_channelbootstrap.cc) has its watcher posts tasks (in Watcher::CallOnHandleReady) instead of calling it directly. Since all happens on the IO thread, it should call directly. It seems that Watcher::task_runner_ is a sequence task runner for the IO thread but not the same as the one returned by base::ThreadTaskRunnerHandle::Get() on the IO thread. Changing Watcher::task_runner_ to base::ThreadTaskRunnerHandle::Get() caused some child processes to still post, so it would probably be a good idea to tag Watcher instances created from ChannelAssociatedGroupController as should_not_post and assert if they pos so we catch these unnecessary posts.
,
May 29 2017
,
May 29 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
,
Nov 15
AFAICT this stuff is WAI. Not sure if there was a bug fixed or if the original report was missing something. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by roc...@chromium.org
, Jan 13 2017