New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680619 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

MD Settings: Incognito exceptions don't show up immediately.

Project Member Reported by dpa...@chromium.org, Jan 12 2017

Issue description

Repro steps (see screencast).
1) Navigate to chrome://md-settings/content/flash.
2) Observe the list of exceptions (no incogniton exceptions shown).
3) Open an incognito window.

Expected result
Incognito exceptions should be appended to the exceptions list.

Actual result
Incognito exceptions are not appended to the list. Clicking the "Add" exception button triggers the list to eventually be updated.
 
incognito_exceptions.mp4
2.2 MB View Download
Cc: msramek@chromium.org
Components: Privacy

Comment 2 by tbuckley@google.com, Jan 25 2017

Blocking: 671375
Labels: Hotlist-MD-Settings-Privacy-SiteSettings
Labels: M-59
I can still repro
Owner: dschuyler@chromium.org
Status: Assigned (was: Available)
Unsure yet whether either of these is a dupe of the other, but dpapad@ points out that  issue 680619  and this look related. 
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3d26477b0cf74265f99dd09c9f48fa33b73850

commit 2f3d26477b0cf74265f99dd09c9f48fa33b73850
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Mar 24 00:41:06 2017

[MD settings] update content settings when incognito changes

This CL updates the site list data when incognito becomes active or when
it deactivates. E.g. when the first incognito window is created.

BUG= 680619 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2768243002
Cr-Commit-Position: refs/heads/master@{#459304}

[modify] https://crrev.com/2f3d26477b0cf74265f99dd09c9f48fa33b73850/chrome/browser/resources/settings/site_settings/site_list.js

Status: Fixed (was: Started)
Cc: kkaluri@chromium.org
Labels: TE-Verified-59.0.3053.3 TE-Veriifed-M59
Verified this issue on windows 10, Mac 10.12.3, and Ubuntu 14.04 using chrome version #59.0.3053.3

Observed Incognito exceptions is appended to the exceptions list when Incognito window opened and deleted when incognito window is closed


Hence adding TE-Verified labels.
Please find the attached screen-cast for the reference.


Thanks!!

Issue 680619.mp4
1.6 MB View Download

Sign in to add a comment