New issue
Advanced search Search tips

Issue 680616 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 680751



Sign in to add a comment

CrOS: upgrade dev-libs/glib to newer release

Project Member Reported by benchan@chromium.org, Jan 12 2017

Issue description

CrOS currently uses glib 2.34.3 (which was released in later 2012) with some local patches and should upgrade to a newer release. glib upgrade will unblock upgrade of other packages depending on glib.
 
Cc: benchan@chromium.org
Blocking: 680751
Owner: benchan@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Cc: briannorris@chromium.org
 Issue 597446  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/893ed8468b663927e960980ba5cf5f20708bf7ba

commit 893ed8468b663927e960980ba5cf5f20708bf7ba
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:07 2017

shill: remove invocation of g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. This CL removes unnecessary invocations of
g_type_init().

BUG= chromium:680616 
CQ-DEPEND=CL:436384
TEST=Ran shill unit tests and verified shill started properly.

Change-Id: I3ae22f2a8d1ce3c82363658302a4d233cc7440f1
Reviewed-on: https://chromium-review.googlesource.com/436585
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>

[modify] https://crrev.com/893ed8468b663927e960980ba5cf5f20708bf7ba/shill.gyp
[modify] https://crrev.com/893ed8468b663927e960980ba5cf5f20708bf7ba/daemon_task.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/87f86f71e0cc63c5250cc5a7ccb7821eabce03fc

commit 87f86f71e0cc63c5250cc5a7ccb7821eabce03fc
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:19:18 2017

dev-libs/glib: upgrade to 2.36.4

This CL imports glib 2.36.4 from upstream Gentoo, with the following
local modifications for Chromium OS:

- CL:262610: glib-gdbus-tool-wait-for-well-known-name.patch isn't
  available in glib 2.36 and is thus carried over.

- CL:210563: The 'cros_host' USE flag is carried over to allow gresource
  to be installed only on the host.

- CL:202308: The 'mime' USE flag is carried over to control the
  x11-misc/shared-mime-info dependency. The 'mime' USE flag has been
  added to the glib ebuild since 2.38, but not in 2.36.

- glib-2.36.4-g_type_init.patch is added to temporarily remove the
  'deprecated' attribute on g_type_init() in order to allow us to
  gradually migrate existing Chromium OS code to remove all call sites
  of g_type_init(), which has been deprecated since glib 2.36.

BUG= chromium:680616 
TEST=Remote trybot runs on paladin, release, and, chromium-sdk builders.

Change-Id: I3e05faf5ca3441ed31e91cee70d31577e9abaa59
Reviewed-on: https://chromium-review.googlesource.com/436384
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/4670aae8695cd61ac9b70446932021c641701b79/dev-libs/glib/files/glib-2.32.4-bashcomp.patch
[add] https://crrev.com/87f86f71e0cc63c5250cc5a7ccb7821eabce03fc/dev-libs/glib/files/glib-2.36.4-znodelete.patch
[add] https://crrev.com/87f86f71e0cc63c5250cc5a7ccb7821eabce03fc/dev-libs/glib/files/glib-2.35.x-external-gdbus-codegen.patch
[add] https://crrev.com/87f86f71e0cc63c5250cc5a7ccb7821eabce03fc/dev-libs/glib/files/glib-2.36.4-g_type_init.patch
[delete] https://crrev.com/4670aae8695cd61ac9b70446932021c641701b79/dev-libs/glib/files/glib-2.31.x-external-gdbus-codegen.patch
[delete] https://crrev.com/4670aae8695cd61ac9b70446932021c641701b79/dev-libs/glib/files/glib-2.32.4-CVE-2012-3524.patch
[delete] https://crrev.com/4670aae8695cd61ac9b70446932021c641701b79/dev-libs/glib/glib-2.34.3-r4.ebuild
[delete] https://crrev.com/4670aae8695cd61ac9b70446932021c641701b79/dev-libs/glib/files/glib-2.34.0-testsuite-skip-gdbus-auth-tests.patch
[delete] https://crrev.com/4670aae8695cd61ac9b70446932021c641701b79/dev-libs/glib/glib-2.34.3.ebuild
[delete] https://crrev.com/4670aae8695cd61ac9b70446932021c641701b79/dev-libs/glib/files/glib-2.34.3-automake-1.13.patch
[modify] https://crrev.com/87f86f71e0cc63c5250cc5a7ccb7821eabce03fc/dev-libs/glib/Manifest
[add] https://crrev.com/87f86f71e0cc63c5250cc5a7ccb7821eabce03fc/dev-libs/glib/glib-2.36.4-r1.ebuild
[delete] https://crrev.com/4670aae8695cd61ac9b70446932021c641701b79/dev-libs/glib/files/glib-2.34.0-G_GNUC_UNUSED.patch

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mtpd/+/af5ebffb9462fd6fab9d9d8e230af76bc5c122c6

commit af5ebffb9462fd6fab9d9d8e230af76bc5c122c6
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:11 2017

mtpd: guard invocation of g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. This CL guards the invocation of
g_type_init() with the glib version check marco.

BUG= chromium:680616 
TEST=Ran mtpd unit tests.
TEST=Verified that mtpd worked with glib 2.34 and 2.36.

Change-Id: I3344acf323396fd06065846f746d30c42e6cf451
Reviewed-on: https://chromium-review.googlesource.com/436484
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/af5ebffb9462fd6fab9d9d8e230af76bc5c122c6/main.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/ed1860174cf5d78821ed6fc9ee0906ce6cdfb300

commit ed1860174cf5d78821ed6fc9ee0906ce6cdfb300
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:04 2017

libbrillo: remove invocation of g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. This CL removes unnecessary invocations of
g_type_init() and related comments in the code.

BUG= chromium:680616 
CQ-DEPEND=CL:436384
TEST=Ran libbrillo unit tests.
TEST=Verified that CrOS DBus daemons based on libbrillo worked.

Change-Id: Iac630d3d0b75f47e3d54826bd5ac0bb2e91c79c9
Reviewed-on: https://chromium-review.googlesource.com/436584
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/ed1860174cf5d78821ed6fc9ee0906ce6cdfb300/brillo/glib/dbus.h
[modify] https://crrev.com/ed1860174cf5d78821ed6fc9ee0906ce6cdfb300/brillo/glib/abstract_dbus_service.h
[modify] https://crrev.com/ed1860174cf5d78821ed6fc9ee0906ce6cdfb300/brillo/glib/object.h
[modify] https://crrev.com/ed1860174cf5d78821ed6fc9ee0906ce6cdfb300/testrunner.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1cee647266d75f944a4057ddf86d7014cda0b5f2

commit 1cee647266d75f944a4057ddf86d7014cda0b5f2
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:01 2017

login: remove comment regarding g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. As invocations of g_type_init() are being
removed from the code, this CL removes a comment regarding
g_type_init().

BUG= chromium:680616 
CQ-DEPEND=CL:436384
TEST=Ran unit tests.

Change-Id: Icb2ab11fb458620688500e875d4897cb9bad24a6
Reviewed-on: https://chromium-review.googlesource.com/436565
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/1cee647266d75f944a4057ddf86d7014cda0b5f2/login_manager/session_manager_service.h

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7f308b2c0ffedcbc42c98ca5aca52e6fd8960e05

commit 7f308b2c0ffedcbc42c98ca5aca52e6fd8960e05
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:02 2017

cros-disks: remove invocation of g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. This CL removes unnecessary invocations of
g_type_init().

BUG= chromium:680616 
CQ-DEPEND=CL:436384
TEST=Ran cros-disks unit tests and platform_CrosDisksDBus autotest.

Change-Id: I383d0bc9965a1c714151232c9773887fc5331be9
Reviewed-on: https://chromium-review.googlesource.com/436566
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7f308b2c0ffedcbc42c98ca5aca52e6fd8960e05/cros-disks/cros-disks.gyp
[modify] https://crrev.com/7f308b2c0ffedcbc42c98ca5aca52e6fd8960e05/cros-disks/main.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/414c9074bdd54bee1ce725b0b01799fc91a9c879

commit 414c9074bdd54bee1ce725b0b01799fc91a9c879
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:02 2017

wimax: remove invocation of g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. This CL removes unnecessary invocations of
g_type_init().

BUG= chromium:680616 
CQ-DEPEND=CL:436384
TEST=Ran wimax-manager unit tests and network_WiMaxSmoke autotest.

Change-Id: I439d5756ba53d0d1c710dee7ed434c4d7eec8901
Reviewed-on: https://chromium-review.googlesource.com/436567
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/414c9074bdd54bee1ce725b0b01799fc91a9c879/wimax_manager/wimax_manager.gyp
[modify] https://crrev.com/414c9074bdd54bee1ce725b0b01799fc91a9c879/wimax_manager/main.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/491627e6d5ecb35152ccc583c1227582df64172b

commit 491627e6d5ecb35152ccc583c1227582df64172b
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:02 2017

image-burner: remove invocation of g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. This CL removes unnecessary invocations of
g_type_init().

BUG= chromium:680616 
CQ-DEPEND=CL:436384
TEST=Ran image-burner unit tests and Chromebook Recovery Utility.

Change-Id: Ifc00964c107e4f52eb40dfedb5b896e3975c3032
Reviewed-on: https://chromium-review.googlesource.com/436568
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/491627e6d5ecb35152ccc583c1227582df64172b/image-burner/image_burner_main.cc
[modify] https://crrev.com/491627e6d5ecb35152ccc583c1227582df64172b/image-burner/image_burn_service.h

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a9620b98f94659408a5d7ccb06c4a69dc0364d5c

commit a9620b98f94659408a5d7ccb06c4a69dc0364d5c
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:02 2017

cryptohome: remove invocation of g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. This CL removes unnecessary invocations of
g_type_init().

BUG= chromium:680616 
CQ-DEPEND=CL:436384
TEST=Ran cryptohome unit tests and autotest.

Change-Id: I8d1a2c6d22fd6f5840fcd7a76dc1e315b69dd1ab
Reviewed-on: https://chromium-review.googlesource.com/436569
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>

[modify] https://crrev.com/a9620b98f94659408a5d7ccb06c4a69dc0364d5c/cryptohome/service.h
[modify] https://crrev.com/a9620b98f94659408a5d7ccb06c4a69dc0364d5c/cryptohome/cryptohome.cc
[modify] https://crrev.com/a9620b98f94659408a5d7ccb06c4a69dc0364d5c/cryptohome/cryptohomed.cc
[modify] https://crrev.com/a9620b98f94659408a5d7ccb06c4a69dc0364d5c/cryptohome/cryptohome_testrunner.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ceda568c3a90786283faa9aa00150cba740a56fb

commit ceda568c3a90786283faa9aa00150cba740a56fb
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 03 13:15:03 2017

p2p: remove invocation of g_type_init()

g_type_init() has been deprecated (and also marked with the attribute
'deprecated') since glib 2.36 as the glib type system is now
automatically initialized. This CL removes unnecessary invocations of
g_type_init().

BUG= chromium:680616 
CQ-DEPEND=CL:436384
TEST=Ran p2p unit tests and autotest.

Change-Id: I2335852a7fe8492f2f8932ccfc2a0d2cc95f600a
Reviewed-on: https://chromium-review.googlesource.com/436570
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ceda568c3a90786283faa9aa00150cba740a56fb/p2p/http_server/testrunner.cc
[modify] https://crrev.com/ceda568c3a90786283faa9aa00150cba740a56fb/p2p/client/testrunner.cc
[modify] https://crrev.com/ceda568c3a90786283faa9aa00150cba740a56fb/p2p/client/main.cc
[modify] https://crrev.com/ceda568c3a90786283faa9aa00150cba740a56fb/p2p/server/testrunner.cc
[modify] https://crrev.com/ceda568c3a90786283faa9aa00150cba740a56fb/p2p/common/testrunner.cc
[modify] https://crrev.com/ceda568c3a90786283faa9aa00150cba740a56fb/p2p/server/main.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c04e7eb06002faebfc0959f11fc8723e4bcf37d2

commit c04e7eb06002faebfc0959f11fc8723e4bcf37d2
Author: Ben Chan <benchan@chromium.org>
Date: Sat Feb 04 04:01:46 2017

dev-libs/glib: remove g_type_init patch

This CL removes the g_type_init patch as invocations of g_type_init() in
Chromium OS code base are now either removed or guarded with glib
version check.

BUG= chromium:680616 
TEST=Remote trybot runs on paladin, release, and, chromium-sdk builders.

Change-Id: I5df83a494a345703968e902ca87c3d60fe6b4406
Reviewed-on: https://chromium-review.googlesource.com/437604
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/8f23151bd44f001aa9b8620ccbf1ef0508f16bcd/dev-libs/glib/files/glib-2.36.4-g_type_init.patch
[rename] https://crrev.com/c04e7eb06002faebfc0959f11fc8723e4bcf37d2/dev-libs/glib/glib-2.36.4-r2.ebuild

Project Member

Comment 16 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/6c176cecbf9e35c0e6e440bf448a0ee9376cbd62

commit 6c176cecbf9e35c0e6e440bf448a0ee9376cbd62
Author: Ben Chan <benchan@chromium.org>
Date: Fri May 05 02:09:23 2017

app-portage/elt-patches: import 20170317 from upstream

This CL imports app-portage/elt-patches-20170317 from upstream Gentoo,
which is needed by eclass/epunt-cxx.eclass. EAPI is downgraded from 6 to
5, and KEYWORDS is changed to "*".

BUG= chromium:680616 
TEST=Remote trybot runs.

Change-Id: I4b8e3f358767914506ee53a68f2c09a3d0fc3e54
Reviewed-on: https://chromium-review.googlesource.com/493550
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/6c176cecbf9e35c0e6e440bf448a0ee9376cbd62/app-portage/elt-patches/metadata.xml
[add] https://crrev.com/6c176cecbf9e35c0e6e440bf448a0ee9376cbd62/app-portage/elt-patches/elt-patches-20170317.ebuild
[add] https://crrev.com/6c176cecbf9e35c0e6e440bf448a0ee9376cbd62/app-portage/elt-patches/Manifest

Project Member

Comment 17 by bugdroid1@chromium.org, May 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/0d24ea1e038f7f741075b2c46cdfcd8302256b3c

commit 0d24ea1e038f7f741075b2c46cdfcd8302256b3c
Author: Ben Chan <benchan@chromium.org>
Date: Sun May 07 02:52:32 2017

eclass: import epunt-cxx.eclass from upstream Gentoo

This CL imports epunt-cxx.eclass (at commit
71791dbb2b3c55e8b99b769a5f86f377df594a46) from upstream Gentoo.

BUG= chromium:680616 
TEST=Remote trybot runs.

Change-Id: I7c6bdd64e6633a0e36626c8c34e688a891aed024
Reviewed-on: https://chromium-review.googlesource.com/493551
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/0d24ea1e038f7f741075b2c46cdfcd8302256b3c/eclass/epunt-cxx.eclass

Project Member

Comment 18 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bcc41e14c1a8a39b0c3b74bf61d1ef479b185f39

commit bcc41e14c1a8a39b0c3b74bf61d1ef479b185f39
Author: Ben Chan <benchan@chromium.org>
Date: Sat May 13 03:58:05 2017

profile: compile libpcre with static-libs for sdk

As glib is compiled with static-libs for the sdk profile, its libpcre
dependency also needs to be compiled with static-libs.

BUG= chromium:680616 
TEST=Remote trybot runs on paladin, release and chromiumos-sdk builders.

Change-Id: I7d92a3dcf01c9b784a14b3c11a35e04bc0aeab11
Reviewed-on: https://chromium-review.googlesource.com/505452
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/bcc41e14c1a8a39b0c3b74bf61d1ef479b185f39/profiles/targets/sdk/package.use

Project Member

Comment 19 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/3a26162e280e8efea765b6401af6f2dfedc36bd6

commit 3a26162e280e8efea765b6401af6f2dfedc36bd6
Author: Ben Chan <benchan@chromium.org>
Date: Sat May 13 03:58:08 2017

eclass: pull in multilib updates

This CL pulls in the latest multilib.eclass (at commit
61b861acd7b49083dab687e133f30f3331cb7480) from upstream Gentoo. The
newer multilib.eclass provides get_exeext(), which is needed for
upgrading other packages such as glib.

BUG= chromium:680616 
TEST=Remote trybot runs on paladin, release and chromiumos-sdk builders.

Change-Id: Ib5a5d5bf2666be081e34b301fdf9fd268163053b
Reviewed-on: https://chromium-review.googlesource.com/505258
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3a26162e280e8efea765b6401af6f2dfedc36bd6/eclass/multilib.eclass

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/542d3b33ee6ba5cddbd033261083db80f058dab0

commit 542d3b33ee6ba5cddbd033261083db80f058dab0
Author: Ben Chan <benchan@chromium.org>
Date: Fri Jun 23 07:51:27 2017

net-analyzer/wireshark: replace g_memmove with memmove

glib 2.50.3 has removed the deprecated g_memmove. This CL backports
upstream wireshark patches that replace g_memmove with memmove.

BUG= chromium:680616 
TEST=Build wireshark with glib 2.50.3.

Change-Id: Iaab3537b6a06496d89367d6a41adce8185fd7aec
Reviewed-on: https://chromium-review.googlesource.com/544517
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/542d3b33ee6ba5cddbd033261083db80f058dab0/net-analyzer/wireshark/wireshark-1.10.5.ebuild
[add] https://crrev.com/542d3b33ee6ba5cddbd033261083db80f058dab0/net-analyzer/wireshark/files/wireshark-1.10.5-g_memmove.patch
[rename] https://crrev.com/542d3b33ee6ba5cddbd033261083db80f058dab0/net-analyzer/wireshark/wireshark-1.10.5-r4.ebuild

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/dc7b1b7a0722f7ff70831b27441ee443953a5ba2

commit dc7b1b7a0722f7ff70831b27441ee443953a5ba2
Author: Ben Chan <benchan@chromium.org>
Date: Fri Jun 23 10:14:50 2017

dev-util/dbus-glib: upgrade to 0.108

BUG= chromium:680616 
TEST=Remote trybot runs on paladin, release and chromiumos-sdk builders.

Change-Id: Iff378bf6471e8483a3ffaf691c6414496cce8535
Reviewed-on: https://chromium-review.googlesource.com/542955
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/dc7b1b7a0722f7ff70831b27441ee443953a5ba2/dev-libs/dbus-glib/Manifest
[rename] https://crrev.com/dc7b1b7a0722f7ff70831b27441ee443953a5ba2/dev-libs/dbus-glib/dbus-glib-0.108.ebuild

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d7fe01a876a001e7d14748f0af4017ba99525d62

commit d7fe01a876a001e7d14748f0af4017ba99525d62
Author: Ben Chan <benchan@chromium.org>
Date: Tue Jun 27 03:20:52 2017

dev-libs/dbus-glib: address unused-function warnings

clang may generate an unused-function warning on a function that is
marked 'static inline'. This patch annotates those static inline
functions generated by dbus-binding-tool with '__attribute__((unused))'
to suppress the warning.

BUG= chromium:680616 
CQ-DEPEND=CL:542955
TEST=Remote trybot runs on paladin, release and chromiumos-sdk builders.

Change-Id: Iecf83c5b5e36dfc26a025b38ae3d7cb22be93433
Reviewed-on: https://chromium-review.googlesource.com/542935
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[add] https://crrev.com/d7fe01a876a001e7d14748f0af4017ba99525d62/dev-libs/dbus-glib/dbus-glib.bashrc
[add] https://crrev.com/d7fe01a876a001e7d14748f0af4017ba99525d62/dev-libs/dbus-glib/files/dbus-glib-0.108-unused-function.patch

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dbb605633d2f05b62e23e62e000789cb535ba887

commit dbb605633d2f05b62e23e62e000789cb535ba887
Author: Ben Chan <benchan@chromium.org>
Date: Wed Sep 06 08:05:33 2017

dev-libs/glib: upgrade to 2.50.3

This CL imports glib 2.50.3 from upstream Gentoo, with the following
local modifications for Chromium OS:

- EAPI is downgraded from 6 to 5. epatch is used instead of eapply.

- CL:262610: glib-gdbus-tool-wait-for-well-known-name.patch isn't
  available in glib 2.36 and is thus carried over.

- CL:210563: The 'cros_host' USE flag is carried over to allow gresource
  to be installed only on the host.

- CL:508210, CL:509921: The 'doc' USE flag is carried over to
  conditionally enable doc building and related dependencies.

The following local modification is dropped as it has been included in
upstream ebuild:

- CL:202308: The 'mime' USE flag has been added to glib ebuild since
  2.38 to control the x11-misc/shared-mime-info dependency.

BUG= chromium:680616 
CQ-DEPEND=CL:505095
TEST=Remote trybot runs on paladin, release, and, chromium-sdk builders.

Change-Id: Ic0c71ae9692e38e524f5e3dfddb2fe661bdeb45e
Reviewed-on: https://chromium-review.googlesource.com/505453
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/6c6237f04d119bad10b1bb6a21d10de36b5075a2/dev-libs/glib/files/glib-2.36.4-znodelete.patch
[add] https://crrev.com/dbb605633d2f05b62e23e62e000789cb535ba887/dev-libs/glib/files/glib-2.50.3-fix-gdatetime-tests.patch
[add] https://crrev.com/dbb605633d2f05b62e23e62e000789cb535ba887/dev-libs/glib/glib-2.50.3-r1.ebuild
[rename] https://crrev.com/dbb605633d2f05b62e23e62e000789cb535ba887/dev-libs/glib/files/glib-2.50.0-external-gdbus-codegen.patch
[delete] https://crrev.com/6c6237f04d119bad10b1bb6a21d10de36b5075a2/dev-libs/glib/glib-2.36.4-r4.ebuild
[modify] https://crrev.com/dbb605633d2f05b62e23e62e000789cb535ba887/dev-libs/glib/Manifest
[delete] https://crrev.com/6c6237f04d119bad10b1bb6a21d10de36b5075a2/dev-libs/glib/files/glib-2.12.12-fbsd.patch
[delete] https://crrev.com/6c6237f04d119bad10b1bb6a21d10de36b5075a2/dev-libs/glib/files/glib-2.34.0-testsuite-skip-thread4.patch

Status: Fixed (was: Started)
glib is now at 2.50.3

Comment 27 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 28 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment