New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 680614 link

Starred by 1 user
Status: Fixed
Owner:
s...@chromium.org
Closed: Jan 2017
Cc:
█ maxbogue@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[USS] Rename OnMetadataLoaded to ModelReadyForSyncing

Project Member Reported by s...@chromium.org, Jan 12 2017 
https://cs.chromium.org/chromium/src/components/sync/model/model_type_change_processor.h?l=54

OnMetadataLoaded does not really convey the purpose of the method, which is to indicate to the processor that the type is ready to start syncing. It especially does not convey that you have to call it before sync can begin.

This isn't really an observer/event scenario, it's the bridge's responsibility to give the proc the metadata, and it's a pivotal point in their initialization. The name should at least try to communicate this.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7aece49f006dc71eb73e924e65f6a44d6a094d9

commit a7aece49f006dc71eb73e924e65f6a44d6a094d9
Author: skym <skym@chromium.org>
Date: Thu Jan 19 16:25:27 2017

[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes and comment updates.

BUG= 680614 
TBR=olivierrobin

Review-Url: https://codereview.chromium.org/2621373004
Cr-Commit-Position: refs/heads/master@{#444759}

[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/reading_list/ios/reading_list_store.cc
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/reading_list/ios/reading_list_store.h
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/device_info/device_info_sync_bridge.cc
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/device_info/device_info_sync_bridge_unittest.cc
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model/fake_model_type_change_processor.cc
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model/fake_model_type_change_processor.h
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model/model_type_change_processor.h
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model/model_type_sync_bridge.cc
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model/model_type_sync_bridge.h
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model/model_type_sync_bridge_unittest.cc
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model_impl/shared_model_type_processor.cc
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model_impl/shared_model_type_processor.h
[modify] https://crrev.com/a7aece49f006dc71eb73e924e65f6a44d6a094d9/components/sync/model_impl/shared_model_type_processor_unittest.cc

Comment 2 by s...@chromium.org, Jan 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment