New issue
Advanced search Search tips

Issue 680605 link

Starred by 1 user
Status: Fixed
Owner:
aga...@chromium.org
Closed: Jan 2017
Cc:
tandrii@chromium.org
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:5255


Sign in to add a comment

"git cl upload" sends notifications to CC even without --send-email

Project Member Reported by dsinclair@chromium.org, Jan 12 2017 
I pushed a CL up to Gerrit and it emailed pdfium-reviews@. This was unexpected as I thought it would work the same way as rietveld where the email would not get sent until I went to the site and sent it manually.

I'd prefer the rietveld way as my CL may not be ready for review, or I may delete the CL as I discover issues. The pdfium-reviews email should not go out until I'm ready.


https://pdfium-review.googlesource.com/c/2175/

Comment 1 by aga...@chromium.org, Jan 12 2017 

This CC email is specified by codereview.settings (https://pdfium.googlesource.com/pdfium/+/e7fb8eb3e9f220a5f0c852f0238ab8d536a8bc9d/codereview.settings) which means it is added to the CL by "git cl upload" (not by the server itself).

The initial "git cl upload" is supposed to set NOTIFY=false unless the user passes "--send-email", so this is a bug in git-cl.

Andy, can you move this to the chromium tracker?

Comment 2 by aga...@chromium.org, Jan 12 2017

Labels: -Restrict-View-Google

Comment 3 by andyb...@chromium.org, Jan 12 2017

Project: chromium
Moved issue gerrit:5255 to now be  issue chromium:680605 .

Comment 4 by aga...@chromium.org, Jan 12 2017

Cc: aga...@chromium.org tandrii@chromium.org
Components: Infra>Codereview>Gerrit
Labels: Milestone-Dogfood Proj-Gerrit-Migration
Status: Available (was: New)
Summary: "git cl upload" sends notifications to CC even without --send-email (was: Gerrit emails cc list automatically)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/59f4851751df4f08a4f02d8ddedfd4e72e7f2cab

commit 59f4851751df4f08a4f02d8ddedfd4e72e7f2cab
Author: Aaron Gable <agable@chromium.org>
Date: Thu Jan 12 18:54:46 2017

Don't send email to CCs by default on initial upload

It looks like this regressed when we switched from specifying CCs
via the refspec arguments to using the API.

BUG= 680605 

Change-Id: Iabd397b639989f050932188b1a1aa488639ffbbe
Reviewed-on: https://chromium-review.googlesource.com/427344
Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/59f4851751df4f08a4f02d8ddedfd4e72e7f2cab/gerrit_util.py
[modify] https://crrev.com/59f4851751df4f08a4f02d8ddedfd4e72e7f2cab/git_cl.py
[modify] https://crrev.com/59f4851751df4f08a4f02d8ddedfd4e72e7f2cab/tests/git_cl_test.py

Comment 6 by aga...@chromium.org, Jan 12 2017

Owner: aga...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment