web_bluetooth.mojom needs better comments/docs |
|||
Issue description
dcheng in review pointed out that most of the structures we use are not defined well. For example:
struct WebBluetoothRemoteGATTCharacteristic {
string instance_id;
string uuid;
uint32 properties;
};
We should explain what these are, what format the strings can be in, etc.
,
Jan 12 2017
FYI: the IDs are platform specific opaque identifiers. Each platform generates them differently, and e.g. on linux they come from the drivers, while on Android we generate our own. They are not intended to be exposed to javascript code, but are necessary for the renderer implementation to be able to refer to specific instances.
,
Jan 13 2017
In addition to document the ID's, we need to also document when |services_uuid|, |characteristics_uuid|, |descriptor_uuid| can be null and what it's used for.
,
Jan 14 2017
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69022eccc884e5541518c448e965f79f8aa17f95 commit 69022eccc884e5541518c448e965f79f8aa17f95 Author: scheib <scheib@chromium.org> Date: Wed Jan 18 00:19:41 2017 bluetooth: web: web_bluetooth.mojom comments and UUID type fix. In https://codereview.chromium.org/2466223002 dcheng requested improved comments in the web_bluetooth.mojom file. This change: + References where to understand Bluetooth GATT terms. + Describes the use of instance IDs and UUIDs. + Clarifies how attribute retrieval is done. + Upgrades all use of UUIDs to be of type 'bluetooth.mojom.UUID'. BUG= 680587 Review-Url: https://codereview.chromium.org/2635473004 Cr-Commit-Position: refs/heads/master@{#444200} [modify] https://crrev.com/69022eccc884e5541518c448e965f79f8aa17f95/content/browser/bluetooth/web_bluetooth_service_impl.cc [modify] https://crrev.com/69022eccc884e5541518c448e965f79f8aa17f95/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
,
Jan 19 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dougt@chromium.org
, Jan 12 2017