New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680568 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 679424



Sign in to add a comment

Implement the LoFiCacheDisabled Integration Test with ChromeDriver

Project Member Reported by robertogden@chromium.org, Jan 12 2017

Issue description

Correctness measurement for Lo-Fi placeholder is not loaded from cache when a page is reloaded with LoFi disabled. First a test page is opened with LoFi and chrome proxy enabled. This allows Chrome to cache the LoFi placeholder image. The browser is restarted with LoFi disabled and the same test page is loaded. This second page load should not pick the LoFi placeholder from cache and original image should be loaded. This test should be run with --profile-type=default command line for the same user profile and cache to be used across the two page loads.

New File Name: lofi.py
New Method Name: testLoFiCacheDisabled

Telemetry PageSet: https://cs.chromium.org/chromium/src/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi_cache.py
Telemetry Benchmark: https://cs.chromium.org/chromium/src/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py?l=64
Telemetry Measurement: https://cs.chromium.org/chromium/src/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py?q=file:tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py+"class+ChromeProxyCacheLoFiDisabled"
Telemetry Metric: https://cs.chromium.org/chromium/src/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py?q=file:tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py+AddResultsForLoFiCache

(This bug was automatically generated.)

 
Cc: robertogden@chromium.org
Labels: Integration-Test Pri-2 Type-Feature
Status: Available (was: Untriaged)

Comment 2 by bengr@chromium.org, Feb 23 2017

Labels: M-59
Owner: megjab...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4337ecc7263a8707a582b006c99ede5fff76ea2

commit d4337ecc7263a8707a582b006c99ede5fff76ea2
Author: megjablon <megjablon@chromium.org>
Date: Wed Mar 01 21:26:25 2017

Implement the Lo-Fi cache related integration tests with ChromeDriver

Implement both the LoFiCacheDisabled and LoFiProxyDisabled integration
tests in one testLoFiCacheBypass ChromeDriver test. Over half of the
cache tests are identical code for loading the resources into cache and
the existing naming scheme is confusing, so test that turning either
Lo-Fi or the proxy off and refetching the page does not serve cached
transformed resources.

BUG= 680569 ,  680568 

Review-Url: https://codereview.chromium.org/2705413004
Cr-Commit-Position: refs/heads/master@{#454037}

[modify] https://crrev.com/d4337ecc7263a8707a582b006c99ede5fff76ea2/tools/chrome_proxy/webdriver/common.py
[modify] https://crrev.com/d4337ecc7263a8707a582b006c99ede5fff76ea2/tools/chrome_proxy/webdriver/lofi.py

Status: Fixed (was: Assigned)

Sign in to add a comment