New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680567 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 15 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 679424



Sign in to add a comment

Implement the LitePage Integration Test with ChromeDriver

Project Member Reported by robertogden@chromium.org, Jan 12 2017

Issue description

Cc: robertogden@chromium.org
Labels: Integration-Test Pri-2 Type-Feature
Status: Available (was: Untriaged)

Comment 2 by bengr@chromium.org, Feb 23 2017

Labels: M-59
Owner: megjab...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e72a513a6c84075089ecda0570ce658d0b45f6dd

commit e72a513a6c84075089ecda0570ce658d0b45f6dd
Author: megjablon <megjablon@chromium.org>
Date: Mon Feb 27 19:05:41 2017

Implement the LitePage Integration Test with ChromeDriver

BUG= 680567 

Review-Url: https://codereview.chromium.org/2717563002
Cr-Commit-Position: refs/heads/master@{#453279}

[modify] https://crrev.com/e72a513a6c84075089ecda0570ce658d0b45f6dd/tools/chrome_proxy/webdriver/lofi.py

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e72a513a6c84075089ecda0570ce658d0b45f6dd

commit e72a513a6c84075089ecda0570ce658d0b45f6dd
Author: megjablon <megjablon@chromium.org>
Date: Mon Feb 27 19:05:41 2017

Implement the LitePage Integration Test with ChromeDriver

BUG= 680567 

Review-Url: https://codereview.chromium.org/2717563002
Cr-Commit-Position: refs/heads/master@{#453279}

[modify] https://crrev.com/e72a513a6c84075089ecda0570ce658d0b45f6dd/tools/chrome_proxy/webdriver/lofi.py

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e72a513a6c84075089ecda0570ce658d0b45f6dd

commit e72a513a6c84075089ecda0570ce658d0b45f6dd
Author: megjablon <megjablon@chromium.org>
Date: Mon Feb 27 19:05:41 2017

Implement the LitePage Integration Test with ChromeDriver

BUG= 680567 

Review-Url: https://codereview.chromium.org/2717563002
Cr-Commit-Position: refs/heads/master@{#453279}

[modify] https://crrev.com/e72a513a6c84075089ecda0570ce658d0b45f6dd/tools/chrome_proxy/webdriver/lofi.py

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e72a513a6c84075089ecda0570ce658d0b45f6dd

commit e72a513a6c84075089ecda0570ce658d0b45f6dd
Author: megjablon <megjablon@chromium.org>
Date: Mon Feb 27 19:05:41 2017

Implement the LitePage Integration Test with ChromeDriver

BUG= 680567 

Review-Url: https://codereview.chromium.org/2717563002
Cr-Commit-Position: refs/heads/master@{#453279}

[modify] https://crrev.com/e72a513a6c84075089ecda0570ce658d0b45f6dd/tools/chrome_proxy/webdriver/lofi.py

Status: Assigned (was: Fixed)
This test (testLitePageFallback) is always failing, please take a look when you get the chance.

======================================================================
ERROR: testLitePageFallback (lite_page.LitePage)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "~/chromium/src/tools/chrome_proxy/webdriver/lite_page.py", line 65, in testLitePageFallback
    cpat_request = response.request_headers['chrome-proxy-accept-transform']
KeyError: 'chrome-proxy-accept-transform'
What version of chrome are you using that this fails on? This should be working for TOT. testLitePageFallback was just landed for the WebLite to Lo-Fi fallback that was also just landed.
Status: Verified (was: Assigned)
Sure enough, it works on a clean build. Sorry for the noise.

Sign in to add a comment