New issue
Advanced search Search tips

Issue 680562 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 679424



Sign in to add a comment

Implement the ViaHeaderFallback Integration Test with ChromeDriver

Project Member Reported by robertogden@chromium.org, Jan 12 2017

Issue description

In this test, the configured proxy is the chromeproxy-test server which will send back a response without the expected Via header. Chrome is expected to use the fallback proxy and add the configured proxy to the bad proxy list.

New File Name: fallbacks.py
New Method Name: testViaHeaderFallback

Telemetry PageSet: https://cs.chromium.org/chromium/src/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py
Telemetry Benchmark: https://cs.chromium.org/chromium/src/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py?l=216
Telemetry Measurement: https://cs.chromium.org/chromium/src/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py?q=file:tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py+"class+ChromeProxyHTTPFallbackViaHeader"
Telemetry Metric: https://cs.chromium.org/chromium/src/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py?q=file:tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py+AddResultsForHTTPFallback

(This bug was automatically generated.)

 
Cc: robertogden@chromium.org
Labels: Integration-Test Pri-2 Type-Feature
Status: Available (was: Untriaged)

Comment 2 by bengr@chromium.org, Feb 23 2017

Labels: M-59
Owner: sclit...@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dda4c0c9ee86a2764173799140744e205d2ac0f2

commit dda4c0c9ee86a2764173799140744e205d2ac0f2
Author: sclittle <sclittle@chromium.org>
Date: Tue Mar 14 20:13:04 2017

Added Data Saver ChromeDriver test for via header fallback logic.

This test attempts to load a page through a test proxy that doesn't set
the via header properly on a non-4xx response, and verifies that Chrome
falls back to the next proxy and retries the request.

BUG= 680562 

Review-Url: https://codereview.chromium.org/2741263002
Cr-Commit-Position: refs/heads/master@{#456806}

[modify] https://crrev.com/dda4c0c9ee86a2764173799140744e205d2ac0f2/tools/chrome_proxy/webdriver/fallback.py

Status: Fixed (was: Started)

Sign in to add a comment