New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680550 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

[USS] Figure out a good path forward for bridge's handling tombstones during merge.

Project Member Reported by s...@chromium.org, Jan 12 2017

Issue description

In a recent CL Max pointed out that in the bridge's merge we need to check EntityData::is_deleted() https://cs.chromium.org/chromium/src/components/sync/model/entity_data.h?l=73 . If this is true, which it is currently unclear, we're currently 0/4 on doing the right thing. See

https://codereview.chromium.org/2624883002/diff/60001/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
https://cs.chromium.org/chromium/src/components/sync/device_info/device_info_sync_bridge.cc?l=144
https://cs.chromium.org/chromium/src/components/reading_list/ios/reading_list_store.cc?l=215
https://codereview.chromium.org/2432803003/diff/120001/chrome/browser/chromeos/printing/printer_syncable_service.cc

The first step is understanding if this is a possibility/requirement, and partially by looking at what the SyncableServices did. Their SyncData does not have an explicit is deleted accesser, but it could theoretically be inferred from the specifics being empty? https://cs.chromium.org/chromium/src/components/sync/model/sync_data.h

Then, if we decide the bridges do need to perform this check, we need to change our interface in some way to make this clear. Perhaps by doing something similar to SyncChange.
 
I just had a chat with Pavel and In-Ho about this. The sync server will not send down tombstones for first-time syncs, but we should still:

1. Add code in the processor to filter them out.
2. Ensure the migration code doesn't produce them.

Otherwise we will likely see issues with this in the future.
Owner: maxbogue@chromium.org
Status: Started (was: Available)
Status: Fixed (was: Started)

Sign in to add a comment