PluginPowerSaverFilterSameOriginTinyPluginsBrowserTest.BlockSameOriginTinyPlugin is flaky |
||||
Issue descriptionThis browser test is regularly failing on Mac ASan 64 Tests (1) Example builds: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/26544 https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/26557
,
Jan 12 2017
Assign to tommycli@ who recently touched plugin_power_saver_browsertest.cc. tommycli@: If this is not related to your change, please assign it to someone else related. Thanks!
,
Jan 12 2017
That's me. Thanks, I'll investigate now.
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc363b208785eec931ddb29e3d21d2c6a5f98ed5 commit fc363b208785eec931ddb29e3d21d2c6a5f98ed5 Author: tommycli <tommycli@chromium.org> Date: Thu Jan 12 19:12:24 2017 Plugin Power Saver Tiny: Disable flaky test BUG= 680544 TBR= Review-Url: https://codereview.chromium.org/2625273004 Cr-Commit-Position: refs/heads/master@{#443316} [modify] https://crrev.com/fc363b208785eec931ddb29e3d21d2c6a5f98ed5/chrome/browser/plugins/plugin_power_saver_browsertest.cc
,
Jan 13 2017
Issue 681023 has been merged into this issue.
,
Jan 13 2017
,
Feb 3 2017
I'm also seeing this failure infrequently on Linux builders: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/51626
,
Apr 7 2017
This is still flaky on Linux: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54489 I'm disabling it globally: https://codereview.chromium.org/2807523004
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54ae18235d4fc39d7dad8a35f464f76ce75e2aca commit 54ae18235d4fc39d7dad8a35f464f76ce75e2aca Author: ellyjones <ellyjones@chromium.org> Date: Fri Apr 07 14:31:44 2017 plugins: disable BlockSameOriginTinyPlugin test This test is flaky on Linux as well, and was already disabled on Mac and Windows. BUG= 680544 TBR=tommycli@chromium.org Review-Url: https://codereview.chromium.org/2807523004 Cr-Commit-Position: refs/heads/master@{#462851} [modify] https://crrev.com/54ae18235d4fc39d7dad8a35f464f76ce75e2aca/chrome/browser/plugins/plugin_power_saver_browsertest.cc
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e510ebfc9f8565fc8cec92955b631aae49c17fd3 commit e510ebfc9f8565fc8cec92955b631aae49c17fd3 Author: tommycli <tommycli@chromium.org> Date: Thu Apr 20 20:59:48 2017 Plugin Power Saver: Remove racy portion of tests. The removed lines are racy, since it's possible that sometimes the browser process has not received the 'blocked plugin' message from the renderer yet. It would be pretty tricky to coordinate, and I think not worth it. This test should focus on the PPS aspects specifically anyways. BUG= 682039 , 680544 Review-Url: https://codereview.chromium.org/2831003003 Cr-Commit-Position: refs/heads/master@{#466126} [modify] https://crrev.com/e510ebfc9f8565fc8cec92955b631aae49c17fd3/chrome/browser/plugins/plugin_power_saver_browsertest.cc
,
Apr 20 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xlai@chromium.org
, Jan 12 2017