New issue
Advanced search Search tips

Issue 680533 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.download.SystemDownloadNotifierTest#testNotificationNotHandledUntilServiceConnection" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 12 2017

Issue description

"org.chromium.chrome.browser.download.SystemDownloadNotifierTest#testNotificationNotHandledUntilServiceConnection" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyewsSBUZsYWtlInBvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuZG93bmxvYWQuU3lzdGVtRG93bmxvYWROb3RpZmllclRlc3QjdGVzdE5vdGlmaWNhdGlvbk5vdEhhbmRsZWRVbnRpbFNlcnZpY2VDb25uZWN0aW9uDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by xlai@chromium.org, Jan 12 2017

Labels: -Sheriff-Chromium
Owner: qin...@chromium.org
Status: Assigned (was: Untriaged)
qinmin@: Check and find that you have CL that touches SystemDownloadNotifierTest recently. Could you please check if this issue is related to your change? If this is un-related to your change, please assign it to someone else that you think related.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/860143d6bc67646d446e061de9ad873372965bd2

commit 860143d6bc67646d446e061de9ad873372965bd2
Author: qinmin <qinmin@chromium.org>
Date: Fri Jan 13 06:20:24 2017

Fix test flakiness

mStarted is set on UI thread, so we shouldn't check it on other threads.
And there is no point to check it at the beginning of the test since it is always false.

BUG= 680533 

Review-Url: https://codereview.chromium.org/2629703002
Cr-Commit-Position: refs/heads/master@{#443507}

[modify] https://crrev.com/860143d6bc67646d446e061de9ad873372965bd2/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

Comment 3 by qin...@chromium.org, Jan 13 2017

Status: Fixed (was: Assigned)

Comment 4 by xlai@chromium.org, Jan 13 2017

 Issue 680716  has been merged into this issue.

Sign in to add a comment