New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680531 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
OoO until Feb 4th
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 685754

Blocking:
issue 694449



Sign in to add a comment

Construct URLSearchParams from array or object

Project Member Reported by annevank...@gmail.com, Jan 12 2017

Issue description

Comment 1 by mkwst@chromium.org, Jan 13 2017

Cc: toyoshim@chromium.org
Components: Blink>DOM Blink>Network
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Cc: -toyoshim@chromium.org tyoshino@chromium.org

Comment 3 by sigbjo...@opera.com, Feb 28 2017

Blocking: 694449

Comment 4 by sigbjo...@opera.com, Feb 28 2017

Blockedon: 685754

Comment 6 by sigbjo...@opera.com, Mar 17 2017

 Issue 702074  has been merged into this issue.
Owner: raphael....@intel.com
Status: Started (was: Available)
Taking this one as part of the work on  bug 697378 .
Labels: Hotlist-Interop
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e6727773d5da351bc6eb887dc491cc599c9e6d7

commit 8e6727773d5da351bc6eb887dc491cc599c9e6d7
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Tue Jun 27 10:12:39 2017

url: Update URLSearchParams' constructor arguments.

Adapt to https://github.com/whatwg/url/pull/175, which dropped
URLSearchParams itself from the union accepted by the constructor. The
constructor now takes an optional

  (sequence<sequence<USVString>> or record<USVString, USVString> or USVString)

instead. Existing uses of `new URLSearchParams(<existing URLSearchParam>)`
continue to work, as per WebIDL these objects are converted to sequences
because URLSearchParams is iterable.

Intent to ship/implement thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/AGyufsf5XU4/CBeVLmT7BgAJ

Bug:  680531 ,  697378 
Change-Id: Ie82d1151acc4334628be0cc258bc20e5a0dc1d15
Reviewed-on: https://chromium-review.googlesource.com/544919
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482588}
[modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/LayoutTests/external/wpt/url/urlsearchparams-constructor-expected.txt
[modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/LayoutTests/fast/domurl/urlsearchparams-constructor.html
[modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/Source/core/dom/URLSearchParams.cpp
[modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/Source/core/dom/URLSearchParams.h
[modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/Source/core/dom/URLSearchParams.idl

Labels: M-61
Status: Fixed (was: Started)

Sign in to add a comment