[Showcase] Make Showcase depend on strings (and other resources) and metrics |
|||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 1d23821 iOS Version: all Device: all The new architecture promotes a decoupling of UI and logic. Showcase is based on that premise. Some refactored view controllers will still need to use string resources, image resources, register metrics. To that end, Showcase needs to depend on strings, ResourceBundle and metrics. The issue is that these classes bring a lot of dependencies (CommandLine, etc.) that we may not want in Showcase. Action item: support strings, resources and metrics in Showcase, either by depending on the entire branch of dependencies, or by refactoring to cut down the transitive dependencies (which ever makes the most sense).
,
Jan 12 2017
Right, metrics is on the fence we are building between the UI and the logic world. As we progress and face new issues like these, we will have to keep in mind what we let in the UI land and what we keep out of it and be strict about it.
,
Mar 16 2017
,
Apr 14 2017
https://codereview.chromium.org/2767333005 Metrics might be handed differently without the need to have it in Showcase. Closing. |
|||
►
Sign in to add a comment |
|||
Comment 1 by marq@chromium.org
, Jan 12 2017