New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680518 link

Starred by 5 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-XR
Proj-XR-VR

Blocking:
issue 612342



Sign in to add a comment

Servicification: Complete transformation of VR into a service

Project Member Reported by blundell@chromium.org, Jan 12 2017

Issue description

Currently, the VR implementation is split into:
//device/vr [C++]
//chrome/browser/android/vr_shell [C++]
//chrome/android/java/.../vr_shell [Java]

The //chrome-level code calls the //chrome-level C++ code, which then directly depends on //device/vr.

Blink talks to //device/vr via Mojo. That Mojo interface is being ported into the Device Service and thus decoupled from //content. However, to complete the servicification of VR we also need to analyze the coupling between //device/vr and //chrome to determine a design for VR-as-a-whole as a service.

 
Cc: bshe@chromium.org
 issue 672654  is related.

cc bshe, who's written a doc that probably covers this.
Yes, that's definitely related. It would be great to have a link to that doc.
And //chrome/browser/ui/webui/vr_shell [C++] 
//chrome/browser/resources/vr_shell/ [Js and HTML] contains VR implementation, too.
Since I worked on  issue 652080  before, maybe I could help on this.
That's great additional information, thanks! bshe@chromium.org, do you have a link to the doc mentioned in c#1?
Re: helping out, that sounds great as well! It sounds like the starting point is looking at bshe@'s doc and then understanding and coordinating on the work that there is to do and who would do what when.

Comment 6 by xing...@intel.com, Jan 19 2017

Cc: xing...@intel.com
Labels: DeviceService
Documenting some understanding I gained here:

- Web starts a VR presentation flow via VRDisplay::RequestPresent(). That call ultimately ends up in VrShellDelegate.java in //chrome (the dependency is earlier injected via the //device-level GvrDelegateProvider::SetInstance()).
- Seems only to result in functionality (a) on Android and (b) if Daydream or Cardboard are being used.
- Significant coupling to the browser, from browsing the //chrome-level Java code.

It seems like to decouple the VR impl from the browser, substantial parts of the //chrome-level code would need to move into the Device Service. However, the cutpoints are not clear.
Biao's doc can be found at go/webvr-windows-refactor
Can non-googlers access that document?

Comment 11 by bshe@chromium.org, Mar 2 2017

Cc: ddorwin@chromium.org billorr@chromium.org
The above doc is deprecated. A new doc has created by Bill. The doc is probably not at a stage that can be shared publicly. But +ddorwin to answer your question.
Cc: amp@chromium.org
Components: UI>Browser>VR
Labels: Proj-VR
Design and documentation is still a WIP. One of the goals is clearer interfaces and separations. We'll keep this in mind.
Labels: -DeviceService
Removing DeviceService label as VR is not going to end up in the Device Service but rather in a distinct service.
having issue in your browser take help from us opera support number
https://babasupport.org/browser/opera-customer-service/162

Comment 15 by donna...@intel.com, Apr 11 2018

Cc: donna...@intel.com
Labels: -Type-Bug Type-Task
Status: Archived (was: Available)

Sign in to add a comment