Select a better (supports more planes) CRTC for primary display. |
||||||||
Issue descriptionIn order to be able to scanout buffers allocated with certain modifiers (https://code.google.com/p/chrome-os-partner/issues/detail?id=56407) we need to select a CRTC that supports those buffers. https://codereview.chromium.org/2420083003 re-landed on ToT Jan 10, made it to Chrome 57.0.2978.0 but we don't have a cros image with that patch yet. Opening this bug to request merge to 46 as soon as it stays long enough in canary.
,
Jan 12 2017
,
Jan 12 2017
,
Jan 12 2017
> https://codereview.chromium.org/2420083003 re-landed on ToT Jan 10, made it to > Chrome 57.0.2978.0 but we don't have a cros image with that patch yet. I think we do now. Try 9173.0.0, 9176.0.0, or 9177.0.0.
,
Jan 12 2017
CL created by drover at https://codereview.chromium.org/2625813005 Requesting merge to 56.
,
Jan 12 2017
Seting OS-Chrome Merge approved as per chat with dcastagna@
,
Jan 12 2017
,
Jan 13 2017
,
Jan 16 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ee2088a61386825bb9544c8e1fe9a11742868bf commit 7ee2088a61386825bb9544c8e1fe9a11742868bf Author: dcastagna <dcastagna@chromium.org> Date: Tue Jan 17 16:55:54 2017 ozone: Pick CRTCs with majority of planes. When we pick a CRTC to use for a Display, we should prioritize CRTCs that support the majority of overlays. This CL also sorts the connectors before assigning CRTCs. If a connector A supports only a subset of CRTCs supported by connector B, A should be processed first. BUG= 675755 , 680517 NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/93a8c0a676c220b4031af879a2691cb96f053480 Cr-Original-Commit-Position: refs/heads/master@{#439248} Review-Url: https://codereview.chromium.org/2420083003 Cr-Commit-Position: refs/heads/master@{#442472} (cherry picked from commit dcb4b63e4b07bf55e5ad9c20e9346e42c7eeba84) Review-Url: https://codereview.chromium.org/2625813005 Cr-Commit-Position: refs/branch-heads/2924@{#776} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/7ee2088a61386825bb9544c8e1fe9a11742868bf/ui/ozone/platform/drm/common/drm_util.cc
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14715003b1a68375921c4559d9120452839da9d6 commit 14715003b1a68375921c4559d9120452839da9d6 Author: Daniele Castagna <dcastagna@chromium.org> Date: Tue Jan 17 16:58:12 2017 ozone: Select a crtc even when KMS doesn't report any plane for it. crrev.com/2420083003 changed the logic we use to select a crtc. The new code assumes that KMS advertises at least one plane per crtc. This is not true, and it caused not to select any crtc for certain devices. This change removes that assumption. BUG= 680517 ,680798 Review-Url: https://codereview.chromium.org/2629773004 Cr-Commit-Position: refs/heads/master@{#443766} (cherry picked from commit aa96a2c8835f1681fa482a9b31316d2f3cd2ccf6) Review-Url: https://codereview.chromium.org/2636203002 . Cr-Commit-Position: refs/branch-heads/2924@{#777} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/14715003b1a68375921c4559d9120452839da9d6/ui/ozone/platform/drm/common/drm_util.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dcasta...@chromium.org
, Jan 12 2017