Issue 680509 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ warx@chromium.org Last visit > 30 days ago
Closed:	Jan 2017
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Blocking:
issue 633304

Add a grace period between display forced off and locking screen

Project Member Reported by warx@chromium.org, Jan 12 2017

Issue description

For convertible device with "Require screen lock to wake from sleep" pref enabled in settings.

When device is logged in, quickly tap side power button two times, device should not appear locked screen, which means we should add a grace period between display forced off and the actual locking screen operation.

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88b1b7e758f10253dc293c05006c8695fe58079e

commit 88b1b7e758f10253dc293c05006c8695fe58079e
Author: warx <warx@chromium.org>
Date: Thu Jan 12 16:18:43 2017

ash: Add one second grace period For LockScreenIfRequired

Changes:
Add one second grace period For LockScreenIfRequired. Basically, an one second OneShotTimer is used to set/reset the behavior.

BUG= 633304 
BUG= 680509 
TEST=device test, and modify test coverage

Review-Url: https://codereview.chromium.org/2620383003
Cr-Commit-Position: refs/heads/master@{#443254}

[modify] https://crrev.com/88b1b7e758f10253dc293c05006c8695fe58079e/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/88b1b7e758f10253dc293c05006c8695fe58079e/ash/system/chromeos/power/tablet_power_button_controller.h
[modify] https://crrev.com/88b1b7e758f10253dc293c05006c8695fe58079e/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Comment 2 by warx@chromium.org, Jan 12 2017

Status: Fixed (was: Assigned)

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96

commit bb674e1d750b23fe732ce6f37484e1ca3a4e9d96
Author: warx <warx@chromium.org>
Date: Thu Jan 19 18:10:18 2017

Revert "ash: Add one second grace period For LockScreenIfRequired"

This reverts commit 88b1b7e758f10253dc293c05006c8695fe58079e.

changes:
Revert the one second grace period for LockScreenIfRequired for m57 and tot, and explore it later.

BUG= 633304 
BUG= 680509 

Review-Url: https://codereview.chromium.org/2640333002
Cr-Commit-Position: refs/heads/master@{#444787}

[modify] https://crrev.com/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96/ash/system/chromeos/power/tablet_power_button_controller.cc
[modify] https://crrev.com/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96/ash/system/chromeos/power/tablet_power_button_controller.h
[modify] https://crrev.com/bb674e1d750b23fe732ce6f37484e1ca3a4e9d96/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc