New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 680505 link

Starred by 1 user
Status: Fixed
Owner:
mattreynolds@chromium.org
Closed: Jan 2017
Cc:
█ animohan@chromium.org
█ scottj@chromium.org
█ mmo...@chromium.org
█ cco3@chromium.org
mattreynolds@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Omnibox doesn't show PW Zero Suggest results if you type then delete

Project Member Reported by mmo...@chromium.org, Jan 12 2017 
1. Tap omnibox, see ZeroSuggest results
2. Delete all text, still see ZeroSuggest results
3. Type something, see results disappear
4. Delete all text, fail to see ZeroSuggest results re-appear

Not sure if this is an omnibox limitation, or fault of PW provider.  Tested this on iOS.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cac0db7f354b8187b4932f1131d3701c5197d71b

commit cac0db7f354b8187b4932f1131d3701c5197d71b
Author: mattreynolds <mattreynolds@chromium.org>
Date: Thu Jan 26 01:27:06 2017

Show Physical Web zero-suggest omnibox suggestions after query is deleted

The Physical Web omnibox provider provides suggestions when the user first
focuses the omnibox (zero-suggest) as well as after the user begins typing
a query (query suggest). This CL will allow PW zero-suggest suggestions to
be shown when the user has begun typing a query and then deleted it.

BUG= 680505 

Review-Url: https://codereview.chromium.org/2657473003
Cr-Commit-Position: refs/heads/master@{#446193}

[modify] https://crrev.com/cac0db7f354b8187b4932f1131d3701c5197d71b/components/omnibox/browser/physical_web_provider.cc
[modify] https://crrev.com/cac0db7f354b8187b4932f1131d3701c5197d71b/components/omnibox/browser/physical_web_provider_unittest.cc

Comment 2 by mattreynolds@chromium.org, Jan 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment