New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 680455 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Exception list for incognito session remains open even if incognito window is closed.

Reported by vku...@etouch.net, Jan 12 2017

Issue description

Chrome Version:57.0.2979.0 (Official Build)1916748e2f13a9f80080d010a9adc6ba74028a59-refs/heads/master@{#443120} 32/64-bit. 
OS: Windows(7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS).

What steps will reproduce the problem?
(1)Launch chrome,click on wrench > new incognito window
(2)Navigate to chrome://md-settings/content/flash,click on 'add' button under allow section.
(3)Enter any url for e.g https://www.google.co.in and save ,click on iron icon such that list appears.
(4)Close the incognito window and observe.

Actual: Exception list for incognito session remains open even if incognito window is closed.

Expected: Exception list for incognito session should not be displayed once incognito window is closed.

This is a regression issue broken in 'M56' and below is the manual regression range:
Good Build: 56.0.2897.0 
Bad Build:  56.0.2899.0 





 
Actual_Result.mp4
498 KB View Download
Expected_Result.mp4
580 KB View Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Cc: jmukthavaram@chromium.org
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision Pri-1
Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results:

Good build:  56.0.2897.0 (Revision: 426673).
Bad build: 56.0.2900.0  (Revision: 427219).

You are probably looking for a change made after 426711 (known good), but no later than 426712 (first known bad).

CHANGELOG URL:
---------------
The script might not always return single CL as suspectas some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/6cd8cd30ad46f2ac0f9064289f876c73b050dddd..d24c6802d3ac1c6d62b29e6a3fa685a350f694e3

Possible suspect:
-----------------
https://chromium.googlesource.com/chromium/src/+/d24c6802d3ac1c6d62b29e6a3fa685a350f694e3

From the CL above, assigning the issue to the concern owner

@dpapad: Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Review-Url: 
----------
https://chromiumcodereview.appspot.com/2438643004

Thanks.!

Comment 3 by dpa...@chromium.org, Jan 12 2017

Cc: dschuyler@chromium.org
Labels: Proj-MaterialDesign-WebUI

Comment 4 by dpa...@chromium.org, Jan 12 2017

Labels: -Pri-1 Pri-2

Comment 5 by dpa...@chromium.org, Jan 13 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c6b81a4a47c4b9a5f31a65ca0f34e1edc853c35

commit 1c6b81a4a47c4b9a5f31a65ca0f34e1edc853c35
Author: dpapad <dpapad@chromium.org>
Date: Sat Jan 14 00:54:04 2017

MD Settings: Site exceptions, close action menu when list changes.

BUG= 680455 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2634493005
Cr-Commit-Position: refs/heads/master@{#443747}

[modify] https://crrev.com/1c6b81a4a47c4b9a5f31a65ca0f34e1edc853c35/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/1c6b81a4a47c4b9a5f31a65ca0f34e1edc853c35/chrome/test/data/webui/settings/site_list_tests.js

Comment 7 by dpa...@chromium.org, Jan 14 2017

Status: Fixed (was: Started)

Sign in to add a comment