[Missing Tests]: Fix CrOS reverting to Save as PDF and random PDF preview fail |
||
Issue descriptionthestig@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions. Commit: https://codereview.chromium.org/2516523002 Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=666595 Thanks,
,
Jan 12 2017
***Bulk Edit*** Considering Missing tests are P2, but please prioritize and add them asap.
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b28591edaa17ce6bc1e2c951c568066dd2e8ae2 commit 0b28591edaa17ce6bc1e2c951c568066dd2e8ae2 Author: rbpotter <rbpotter@chromium.org> Date: Tue Jan 17 20:31:31 2017 Add print preview test to ensure only 1 preview is started at init This adds a test to ensure only one DOCUMENT_CHANGE and one CAPABILITIES_CHANGE event are issued on initialization of print preview. This ensures that only one preview will be started. Multiple preview starts cause a race condition that created bug 666595 . BUG= 680447 Review-Url: https://codereview.chromium.org/2628393002 Cr-Commit-Position: refs/heads/master@{#444126} [modify] https://crrev.com/0b28591edaa17ce6bc1e2c951c568066dd2e8ae2/chrome/test/data/webui/print_preview.js
,
Jan 19 2017
These regressions were caused by multiple preview requests being issued on initialization whenever there were multiple recent destinations. Added new test that verifies only one request is sent. |
||
►
Sign in to add a comment |
||
Comment 1 by rbpotter@chromium.org
, Jan 12 2017Owner: rbpotter@chromium.org