New issue
Advanced search Search tips

Issue 680438 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Testcase]: Fix renderer crashes due to non-existing RenderFrameImpl

Project Member Reported by ranjitkan@chromium.org, Jan 12 2017

Issue description

ekaramad@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: https://codereview.chromium.org/2526563004

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=664890

Thank you!
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f554a235d98d212b0612cc8188c13de2884fed9

commit 9f554a235d98d212b0612cc8188c13de2884fed9
Author: ekaramad <ekaramad@chromium.org>
Date: Sun Feb 05 04:33:57 2017

Adding tests for two recent regressions due to RenderViewImpl's Swapped Out State

Due to RenderViewImpl::GetWebWidget() returning a WebViewImpl in a swapped out state, a few
regressions were caused where an incoming IPC (which should not have been sent by the browser
in the first place) where handled incorrectly by the renderer and lead to renderer crashes.

This CL will add a test to verify such IPCs do not lead to a crash. This test should be removed
later one when we make sure such IPCs will never be sent by the browser in the given state (perhaps
then the test should move to the browser side and verify we do not send those IPCs).

Some of the IPCs involved relate to IME and TextInputClientMac.

BUG=664890, 668106, 669219,  680438 ,683098

Review-Url: https://codereview.chromium.org/2656433002
Cr-Commit-Position: refs/heads/master@{#448175}

[modify] https://crrev.com/9f554a235d98d212b0612cc8188c13de2884fed9/content/renderer/render_view_browsertest_mac.mm

Status: Fixed (was: Assigned)
Closing the bug since the missing test is added.
Components: Tests>Missing

Sign in to add a comment