Issue metadata
Sign in to add a comment
|
Regression:Unwanted rectangle box is seen on Post sideload UI extension dialog box.
Reported by
dmascare...@etouch.net,
Jan 12 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:57.0.2979.0 (Official Build)1916748e2f13a9f80080d010a9adc6ba74028a59-refs/heads/master@{#443120} 32/64-bit. OS: Windows 10 What steps will reproduce the problem? 1.Launch chrome,click on wrench icon and then click on Newly extension added (any third party) 2.Observe. Actual: Rectangle box is observed on Post sided UI extension dialog box Expected: Rectangle box should not be seen on Post sided UI extension dialog box This is regression issue, broken in 'M 57' and below is manual bisect info: Good build:57.0.2971.0 Bad build:57.0.2972.0 Note:This is Windows 10 specific issue not seen on other OS like Win 7,8,Linux(Ubuntu 14.04 LTS)and Mac (10.11.6, 10.12.1)
,
Jan 12 2017
r441295 is a CL that just changes the file and class names. Since it is view related, I added cc to sky@chromium.org and karandeepb@chromium.org that also have CLs that are in the above bisect.
,
Jan 13 2017
This may be related to my change. Can you provide more detailed repro instructions? I can't invoke this dialog.
,
Jan 13 2017
,
Jan 13 2017
@dmascarenhas: Also, if it's possible can you apply the patch at https://codereview.chromium.org/2630453005 and let me know whether it solves it. Thanks.
,
Jan 13 2017
With response to comment #5: Could you please help us to know in how to apply patch, as we are not aware of the same, Can we verify this in latest canary if the change was pushed.?
,
Jan 13 2017
Nevermind. Can you provide detailed steps to invoke this dialog?
,
Jan 16 2017
With response to comment #7: Above issue is reproducible on Latest Chrome Version: 57.0.2983.0 (Official Build) 266a86c94d34f3c7c3d22ee00624636b801f80d3-refs/heads/master@{#443819} Yellow colour update in wrench for third party comes automatically if third party software like skype is installed on machine.We have to execute test cases related to Post side-load feature.
,
Jan 16 2017
Nevermind. Was able to reproduce. Thanks.
,
Jan 17 2017
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d5cb27adaa84acccadd7880f1a94cb635ebac7c commit 6d5cb27adaa84acccadd7880f1a94cb635ebac7c Author: karandeepb <karandeepb@chromium.org> Date: Wed Jan 18 04:25:26 2017 RenderTextHarfBuzz: Don't draw newline glyph. r441290 added support for multi-line selection to RenderTextHarfBuzz. It also changed the code such that the newline glyph was drawn in some cases. This can lead to the display of an unwanted glyph corresponding to the newline character for certain fonts. To fix, modify RenderTextHarfBuzz::DrawVisualText so that newline glyph is not drawn. BUG= 680430 Review-Url: https://codereview.chromium.org/2630453005 Cr-Commit-Position: refs/heads/master@{#444272} [modify] https://crrev.com/6d5cb27adaa84acccadd7880f1a94cb635ebac7c/ui/gfx/render_text_harfbuzz.cc
,
Jan 18 2017
Should be fixed, please verify.
,
Jan 18 2017
With response to comment #12: Above issue is reproducible on Latest Chrome version:57.0.2985.0 (Official Build) 8c8ff90c8edc7244e4e6d7feda073c76e6949b8e-refs/heads/master@{#444244} Please refer the screencast
,
Jan 18 2017
I don't think the patch is on Canary yet. Please wait before verifying. Thanks. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmascare...@etouch.net
, Jan 12 2017Owner: juncai@chromium.org
Status: Assigned (was: Unconfirmed)