Wrong orientation of dragged image thumbnail |
|||||||||
Issue descriptionChrome Version: 57.0.2980.0 Steps To Reproduce: (1) Prepare an image file with non-zero EXIF orientation. (2) Open the folder in the Files app. (3) Drag the image and cancel by [esc] key. (4) Drag the image and observe the dragged thumbnail. Typically, step 1 can be done by taking a photo by a digital camera in the portrait layout. However, this depends on the implementation of each imaging device. Expected Result: The thumbnail looks same as the original image. Actual Result: The thumbnail image is rotated or flipped wrongly. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always. What is the impact to the user, and is there a workaround? If so, what is it? This is just a problem of the UI appearance. Copy/Move operation should work correctly.
,
Jan 13 2017
This is similar to crbug.com/680414 .
,
Jan 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1a8ea6390809eb8e166631a05eaf97406baf6ca commit b1a8ea6390809eb8e166631a05eaf97406baf6ca Author: yamaguchi <yamaguchi@chromium.org> Date: Mon Jan 16 12:43:25 2017 Apply image transformation for thumbnails loaded by loadDetachedImage. This change will fix 2 parts where we had wrong image orientation, when there's EXIF image rotation/transfomration info. 1. Tooltip thumbnail when an image is dragged in Files app. 2. Low-density image tentatively shown in Gallery app. The drag thumbnail is changed to use the CANVAS mode, because the IMAGE mode still doesn't work correctly. BUG= 680420 , 680414 TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2630283002 Cr-Commit-Position: refs/heads/master@{#443875} [modify] https://crrev.com/b1a8ea6390809eb8e166631a05eaf97406baf6ca/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js [modify] https://crrev.com/b1a8ea6390809eb8e166631a05eaf97406baf6ca/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js [modify] https://crrev.com/b1a8ea6390809eb8e166631a05eaf97406baf6ca/ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js
,
Jan 16 2017
For testing, we can use images downloaded from: https://github.com/recurser/exif-orientation-examples > (1) Prepare an image file with non-zero EXIF orientation. "non-zero" here is inaccurate. The correct condition is "Orientation value other than 1".
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/461ae5544464cdc9d3429311f553568f95da2b2a commit 461ae5544464cdc9d3429311f553568f95da2b2a Author: yamaguchi <yamaguchi@chromium.org> Date: Wed Jan 18 09:25:52 2017 Change the drag thumbnail rendering back to IMAGE mode to fix a regression. Here is the change that caused crbug.com/681796 . This changelist partially reverts its change that affected drag thumbnail rendering. https://codereview.chromium.org/2630283002/ When an item is rendered in CANVAS mode, some metadata field are not filled unlike IMAGE mode. It causes unexpected execution path and outputs an error when clicking on a non-image file whose thumbnail is not yet cached. BUG= 681796 , 680420 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2641743002 Cr-Commit-Position: refs/heads/master@{#444311} [modify] https://crrev.com/461ae5544464cdc9d3429311f553568f95da2b2a/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
,
Jan 18 2017
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a36f4e882b8288ff1f3e07d868ba88e19b0ef654 commit a36f4e882b8288ff1f3e07d868ba88e19b0ef654 Author: yamaguchi <yamaguchi@chromium.org> Date: Fri Feb 17 05:42:41 2017 Rotate an image bitmap in ImageLoader extension when loading detached. This change will fix the image orientation of the thumnail in a tooltip when dragging a JPEG file [whose EXIF orientation != 1] in the Files app. BUG= 680420 TEST=browser_tests --gtest_filter=FileManagerJsTest.ImageOrientation TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2691933007 Cr-Commit-Position: refs/heads/master@{#451231} [modify] https://crrev.com/a36f4e882b8288ff1f3e07d868ba88e19b0ef654/ui/file_manager/file_manager/foreground/js/metadata/image_orientation.js [modify] https://crrev.com/a36f4e882b8288ff1f3e07d868ba88e19b0ef654/ui/file_manager/file_manager/foreground/js/metadata/image_orientation_unittest.js [modify] https://crrev.com/a36f4e882b8288ff1f3e07d868ba88e19b0ef654/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js [modify] https://crrev.com/a36f4e882b8288ff1f3e07d868ba88e19b0ef654/ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js [modify] https://crrev.com/a36f4e882b8288ff1f3e07d868ba88e19b0ef654/ui/file_manager/image_loader/image_loader.js
,
Feb 17 2017
,
Feb 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17312b794d9fa968a6cb09e2cf4eb0e9ecf743df commit 17312b794d9fa968a6cb09e2cf4eb0e9ecf743df Author: yamaguchi <yamaguchi@chromium.org> Date: Mon Feb 20 05:18:32 2017 Take the rotation information from the right source. The transform data may be stored in thumbnail instead of media. The constructor of ThumbnailLoader has the logic to detect the both. This is a follow-up of 2691933007. BUG= 680420 TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2700073003 Cr-Commit-Position: refs/heads/master@{#451559} [modify] https://crrev.com/17312b794d9fa968a6cb09e2cf4eb0e9ecf743df/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js [modify] https://crrev.com/17312b794d9fa968a6cb09e2cf4eb0e9ecf743df/ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js
,
Feb 23 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by yamaguchi@chromium.org
, Jan 13 2017Status: Started (was: Available)