New issue
Advanced search Search tips

Issue 680414 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 656430



Sign in to add a comment

Gallery app: Preview image appears rotated before the full image loads

Project Member Reported by yamaguchi@chromium.org, Jan 12 2017

Issue description

Chrome Version: 57.0.2980.0
Chrome OS Platform: any

Steps To Reproduce:
(1) Make 6 or more JPEG files with non-zero rotation info in its EXIF.
 e.g. 6=RightTop.
(2) Open the first image by Gallery app.
(3) Make sure the app is in the Slide View mode
(4) Click the last image in the bottom list. (Switch between images making sure the image is not prefetched yet)
(5) See the low-resolution image displayed tentatively.

Expected Result:
The last image slides in, displayed with the low-density thumbnail image.
The image is rotated based on the EXIF info.

Actual Result:
The thumbnail image appears without applying the rotation/transformation by the EXIF info.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?
Photos taken by some types of digital cameras and smartphones will be affected.
This issue will be more problematic when a photo is of a large size, as loading actual image will take more time.

 
Description: Show this description
Description: Show this description
Labels: -Pri-3 Pri-2
Owner: yamaguchi@chromium.org
Status: Started (was: Available)
Blocking: 656430
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1a8ea6390809eb8e166631a05eaf97406baf6ca

commit b1a8ea6390809eb8e166631a05eaf97406baf6ca
Author: yamaguchi <yamaguchi@chromium.org>
Date: Mon Jan 16 12:43:25 2017

Apply image transformation for thumbnails loaded by loadDetachedImage.

This change will fix 2 parts where we had wrong image orientation,
when there's EXIF image rotation/transfomration info.
1. Tooltip thumbnail when an image is dragged in Files app.
2. Low-density image tentatively shown in Gallery app.

The drag thumbnail is changed to use the CANVAS mode,
because the IMAGE mode still doesn't work correctly.

BUG= 680420 , 680414 
TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2630283002
Cr-Commit-Position: refs/heads/master@{#443875}

[modify] https://crrev.com/b1a8ea6390809eb8e166631a05eaf97406baf6ca/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
[modify] https://crrev.com/b1a8ea6390809eb8e166631a05eaf97406baf6ca/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js
[modify] https://crrev.com/b1a8ea6390809eb8e166631a05eaf97406baf6ca/ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js

Status: Fixed (was: Started)
For testing, we can use images downloaded from:
https://github.com/recurser/exif-orientation-examples

> (1) Prepare an image file with non-zero EXIF orientation.
"non-zero" here is inaccurate. The correct condition is "Orientation value other than 1".

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)
Cc: noel@chromium.org

Sign in to add a comment