looks like the layout test fast/forms/select/menulist-appearance-basic for Mac10.11 needs to be rebaselined after my change 2608423002

It's still failing. Reverting now.

Mac Retina passes fast/forms/select/menulist-appearance-basic now after the following two reverts:

https://codereview.chromium.org/2627783007/
https://codereview.chromium.org/2629163002/

Marking this as fixed and removing sheriff label.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13949c88b4d34c723921fc1ff975fb6593a651ab

commit 13949c88b4d34c723921fc1ff975fb6593a651ab
Author: ktyliu <ktyliu@chromium.org>
Date: Wed Jan 25 01:40:32 2017

Add NeedsManualRebaseline to TestExpectations that's not covered by CQ

BUG= 680407 

Review-Url: https://codereview.chromium.org/2650963003
Cr-Commit-Position: refs/heads/master@{#445903}

[modify] https://crrev.com/13949c88b4d34c723921fc1ff975fb6593a651ab/third_party/WebKit/LayoutTests/TestExpectations

There is still a NeedsManualRebaseline line in TestExpectations associated with this bug -- I think this issue should be marked as Fixed when the relevant tests are manually rebaselined (with Tools/Scripts/webkit-patch rebaseline <testname>) and the lines are removed from TestExpectations. (NeedsManualRebaseline lines should only be temporary and shouldn't be left in TestExpectations).

Does that sound OK?

I'm no longer a sheriff. Assigning this issue back to the original owner and reviewers of https://codereview.chromium.org/2626973005.

sorry I've left the Chrome team for nearly a year already
would someone be able to help pick this up and just remove NeedsManualRebaseline?

Thanks

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbc0f4f447371f311f8fc0a65e6577fe344607a5

commit bbc0f4f447371f311f8fc0a65e6577fe344607a5
Author: Ned Nguyen <nednguyen@google.com>
Date: Tue Jul 17 17:07:20 2018

Rebaseline fast/forms/select/menulist-appearance-basic.html

Bug:  680407 ,621126
Change-Id: I4be6aeb3cdce35c89abaea8ce756aba456aa36b9
Reviewed-on: https://chromium-review.googlesource.com/1138794
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#575693}
[modify] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/menulist-appearance-basic-expected.png
[modify] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/select/menulist-appearance-basic-expected.txt
[add] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-appearance-basic-expected.png
[add] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/select/menulist-appearance-basic-expected.txt
[add] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/select/menulist-appearance-basic-expected.png
[add] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/select/menulist-appearance-basic-expected.txt
[modify] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-basic-expected.png
[modify] https://crrev.com/bbc0f4f447371f311f8fc0a65e6577fe344607a5/third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-basic-expected.txt

Is this now fixed? :)