Merging a CL about CLD3 into M56 |
|||
Issue descriptionWe'd like to merge the following CL about the language detector CLD3 into M56: https://codereview.chromium.org/2627143002/ It is updating the CLD3 commit hash in DEPS. The main change in the model is static_cast-ing a few chars in ported code to unsigned chars because on some platforms by default char is signed, on others it's unsigned. GitHub page showing the diff: https://github.com/google/cld3/commit/ae02d6b8a2af41e87c956c7c7d3f651a8b7b9e79
,
Jan 13 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 13 2017
Assuming M56 is branch 2924, merged in https://codereview.chromium.org/2629253003 I'll ping bustamante@ about updating the internal DEPS file
,
Jan 13 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/ffc153360158bcac2c885ddb13287b31702e8336 commit ffc153360158bcac2c885ddb13287b31702e8336 Author: Rachel Blum <groby@google.com> Date: Fri Jan 13 20:52:12 2017
,
Jan 13 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/ffc153360158bcac2c885ddb13287b31702e8336 commit ffc153360158bcac2c885ddb13287b31702e8336 Author: Rachel Blum <groby@google.com> Date: Fri Jan 13 20:52:12 2017
,
Jan 16 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 16 2017
Based on comments 3, 4 and 5, this CL has been merged. So, I am removing the merge-approved-56 label and marking as "fixed". |
|||
►
Sign in to add a comment |
|||
Comment 1 by abakalov@chromium.org
, Jan 12 2017Labels: Merge-Request-56